From owner-svn-src-head@freebsd.org Tue Feb 5 17:22:30 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 848CA14C089B; Tue, 5 Feb 2019 17:22:30 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 257C9849DD; Tue, 5 Feb 2019 17:22:30 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id C58413C475F; Tue, 5 Feb 2019 17:22:28 +0000 (UTC) Date: Tue, 5 Feb 2019 17:22:28 +0000 From: Brooks Davis To: John Baldwin Cc: Bruce Evans , Ed Maste , Will Andrews , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325728 - head/lib/libkvm Message-ID: <20190205172228.GC71053@spindle.one-eyed-alien.net> References: <201711112330.vABNUwXC077395@repo.freebsd.org> <20190205202145.A1080@besplex.bde.org> <20190206024025.X3175@besplex.bde.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 257C9849DD X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.88)[-0.881,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Feb 2019 17:22:30 -0000 --4jXrM3lyYWu4nBt5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 05, 2019 at 09:14:46AM -0800, John Baldwin wrote: > On 2/5/19 8:25 AM, Bruce Evans wrote: > > On Tue, 5 Feb 2019, Ed Maste wrote: > >=20 > >> On Tue, 5 Feb 2019 at 05:17, Bruce Evans wrote: > >>> > >>> On Mon, 4 Feb 2019, Ed Maste wrote: > >>>> This should probably be uin64_t to support cross-debugging cores from > >>>> 64-bit machines on 32-bit hosts; also for i386 PAE. Or, on IRC jhb > >>>> suggested we introduce a kpaddr_t typedef akin to kvaddr_t. > >>> > >>> The correct type is vm_paddr_t or maybe a kvm wrapper of this. > >> > >> That precludes cross-arch and cross-size use of kvm_walk_pages; kvm > >> supports this use (see kvm_read2) so it should be a 64-bit kvm > >> wrapper. > >=20 > > kvm or system? kvaddr_t is system and the corresponding physical addre= ss > > type should probably be system too. >=20 > It only needs to exist for libkvm. I want to make a 'portable' libkvm th= at > can be built on non-FreeBSD OS's such as OS X, etc. That is the last thi= ng > needed to let kgdb run on non-FreeBSD OS's to cross-debug crash dumps. F= or > that you would want self-contained types I think such as kvm_vaddr_t and > kvm_paddr_t. I guess I just reused kvaddr_t because it already existed, > but having dedicated types in kvm.h is probably better long term. IIRC, you created kvaddr_t first and I co-opted it for the kernel after finding a namespace collision when I merged the kvaddr_t from CheriBSD. Using kvm_ types seems like a good idea for the reaons you hilight. -- Brooks --4jXrM3lyYWu4nBt5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJcWcZUAAoJEKzQXbSebgfAfRwIAJngvj8MVE/zTdmdixHoAXu6 ngkxu1AXO7bRwAmDfeaUOfGWeyD45J5mi7D8DG56hlxRJiIj4lx6osAwcx3zgUgE /ZJ0UWJFBKIkuGTjX0gQofaBh0ZhDHn8TXWuZOxKSpZY/1TMgJkgS+6UmHI5PTka MEhc3/U0Kj2F76NWG6gqDhLplZY55yqrhDDx/kz9wNTooSziPlyrOnRUa8ACxxSx L1FQd746woAuV2H6c0r8NaMx4Q5PVpzzXk/pNZefW1O7dj4prOYn0IUms5RMXE64 BQqLm5oEZYHmsHNCnns3hNLoqh/qF6Fl1B2vXo/r7EiZBFWKQGH0bLEy7xwRSlY= =YmcG -----END PGP SIGNATURE----- --4jXrM3lyYWu4nBt5--