From owner-cvs-src@FreeBSD.ORG  Thu Sep 11 09:41:54 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 607B116A4BF; Thu, 11 Sep 2003 09:41:54 -0700 (PDT)
Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 090A043FB1; Thu, 11 Sep 2003 09:41:53 -0700 (PDT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.9/8.12.3) with ESMTP id h8BGfoTX034234;
	Thu, 11 Sep 2003 10:41:50 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Thu, 11 Sep 2003 10:41:47 -0600 (MDT)
Message-Id: <20030911.104147.54186211.imp@bsdimp.com>
To: nyan@jp.FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20030911.204333.41730710.nyan@jp.FreeBSD.org>
References: <200309110414.h8B4ERi2062520@repoman.freebsd.org>
	<20030911.204333.41730710.nyan@jp.FreeBSD.org>
X-Mailer: Mew version 2.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: marcel@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/uart uart_cpu_pc98.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Sep 2003 16:41:54 -0000

In message: <20030911.204333.41730710.nyan@jp.FreeBSD.org>
            Takahashi Yoshihiro <nyan@jp.FreeBSD.org> writes:
: In article <200309110414.h8B4ERi2062520@repoman.freebsd.org>
: Warner Losh <imp@FreeBSD.org> writes:
: 
: > imp         2003/09/10 21:14:27 PDT
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/dev/uart         uart_cpu_pc98.c 
: >   Log:
: >   Fix compile on pc98.  Maybe this is correct.
: 
: It should not call i386_bus_space_handle_alloc() directly in device
: driver.  I think that we need to implement bus_space_map() function.

The functions in uart_cpu_* are used for the console port support
before the device system is up and running.  It is currently abusing
bus space handles a little bit here.  Since we're only planning on
supporting console ports on the first two serial ports, the number of
different devices we need to support is sufficiently small that I
thought this abuse was OK.

I mostly wanted to get pc98 compiling again with my commit, so if
there's a more appropriate way to do so, please feel free to instruct
me.

Warner