Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 15 Jun 2005 13:52:47 +0200
From:      Dejan Lesjak <dejan.lesjak@ijs.si>
To:        Alexander Leidinger <Alexander@Leidinger.net>
Cc:        Dejan Lesjak <lesi@FreeBSD.org>, cvs-ports@FreeBSD.org, Michael Johnson <ahze@ahze.net>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/astro/gpsdrive pkg-plist ports/audio/gqmpeg-devel pkg-plist ports/databases/pgworksheet pkg-plist ports/deskutils/hot-babe pkg-plist ports/deskutils/xchm pkg-plist ports/editors/abiword-devel pkg-plist ports/games/crimson ...
Message-ID:  <200506151352.48180.dejan.lesjak@ijs.si>
In-Reply-To: <20050615131035.wyn4a6julw80ow4c@netchild.homeip.net>
References:  <200506150243.j5F2habT053985@repoman.freebsd.org> <200506151217.05514.dejan.lesjak@ijs.si> <20050615131035.wyn4a6julw80ow4c@netchild.homeip.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday 15 of June 2005 13:10, Alexander Leidinger wrote:
> Dejan Lesjak <dejan.lesjak@ijs.si> wrote:
> > On Wednesday 15 of June 2005 12:07, Alexander Leidinger wrote:
> >> Michael Johnson <ahze@ahze.net> wrote:
> >> > On Jun 14, 2005, at 10:43 PM, Dejan Lesjak wrote:
> >> >> lesi        2005-06-15 02:43:36 UTC
> >> >>
> >> >>   FreeBSD ports repository
> >> >>
> >> >>   Log:
> >> >>   Directory share/pixmaps is now included in mtree
> >> >>   (BSD.x11-4.dist rev. 1.27), so remove it from plist.
> >> >
> >> > sweet!
> >>
> >> We need to bump the revision number of those ports, else no updated
> >> packages will be generated.
> >
> > The packages should include mtree that is present when they are generated
> > (at least as far as I understand this). So there's no need to generate
> > packages that only move a directory from +MTREE_DIRS to +CONTENTS.
>
> I was talking about the case where a directory moved from +CONTENTS to the
> mtree file. We don't want to remove a mtree directory in such a port, don't
> we?

Well, if they are empty, why not? It is actually rather unavoidable. I could 
be missing something, but this is how I understand things:
- packages made before this change will have share/pixmap in +CONTENTS, so 
this directory will get removed if it is empty and there is nothing we can 
now do about that, since those packages with their +CONTENTS are already 
installed on users machines. Nothing however should break because of this 
since (1) packages that would rely on this directory being present already 
have it listed either in +CONTENTS or +MTREE_DIRS and (2) things outside of 
packages that would rely on this directory present would already be broken 
before since these packages removed share/pixmaps directory if empty already.
- packages made after this change will have share/pixmaps in +MTREE_DIRS, so 
it won't get removed upon deinstall of such packages. This shouldn't be a 
problem as far as I can see.


Dejan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506151352.48180.dejan.lesjak>