Date: Tue, 13 Apr 2004 18:24:57 +0200 (CEST) From: Roman Neuhauser <neuhauser@chello.cz> To: FreeBSD-gnats-submit@FreeBSD.org Cc: clement@FreeBSD.org Subject: ports/65497: FILES-ify net/pear-Net_NNTP Message-ID: <20040413162457.6C7B72FDA01@isis.wad.cz> Resent-Message-ID: <200404131730.i3DHUHPb045380@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 65497
>Category: ports
>Synopsis: FILES-ify net/pear-Net_NNTP
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 13 10:30:17 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator: Roman Neuhauser
>Release: FreeBSD 4.9-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD isis.wad.cz 4.9-RELEASE-p2 FreeBSD 4.9-RELEASE-p2 #3: Sun Mar 7 02:11:16 CET 2004 root@isis.wad.cz:/usr/obj/usr/src/sys/FREEPUPPY2_6 i386
>Description:
Clement,
what do you think about the attached patch? The port would install
the README file in EXAMPLESDIR, but if you read it you'll see it
only comments on the contents of the example php files, so it IMO
doesn't make sense installing it separately.
>How-To-Repeat:
Don't forget to remove the emptied pkg-plist.
>Fix:
--- net-pear-Net_NNTP.FILES.patch begins here ---
Index: net/pear-Net_NNTP/Makefile
===================================================================
RCS file: /home/ncvs/ports/net/pear-Net_NNTP/Makefile,v
retrieving revision 1.8
diff -u -u -r1.8 Makefile
--- net/pear-Net_NNTP/Makefile 13 Jan 2004 15:04:47 -0000 1.8
+++ net/pear-Net_NNTP/Makefile 12 Apr 2004 23:25:59 -0000
@@ -15,32 +15,11 @@
BUILD_DEPENDS= ${PEARDIR}/Net/Socket.php:${PORTSDIR}/net/pear-Net_Socket
RUN_DEPENDS= ${BUILD_DEPENDS}
+CATEGORY= Net
+FILES= NNTP.php NNTP/Protocol.php NNTP/Header.php NNTP/Message.php
+EXAMPLES= README read.php group.php index.php
+_EXAMPLESDIR= examples/news.php.net
+
.include <bsd.port.pre.mk>
.include "${PORTSDIR}/devel/pear-PEAR/Makefile.common"
-
-LIB_FILES= NNTP/Realtime.php NNTP/Protocol.php NNTP/Header.php NNTP/Message.php
-PORTDOCS= README
-
-.if defined(NOPORTEXAMPLES)
-PLIST_SUB+= PORTEXAMPLES="@comment "
-.else
-PLIST_SUB+= PORTEXAMPLES=""
-.endif
-
-do-install:
- @${MKDIR} ${PEARDIR}/Net/NNTP
- @${CP} -p ${WRKSRC}/NNTP.php ${PEARDIR}/Net
-.for FILE in ${LIB_FILES}
- @${CP} -p ${WRKSRC}/${FILE} ${PEARDIR}/Net/NNTP
-.endfor
- @${CHOWN} -R ${SHAREOWN}:${SHAREGRP} ${PEARDIR}/Net
-.if !(NOPORTEXAMPLES)
- @${MKDIR} ${EXAMPLESDIR}
- @${INSTALL_DATA} ${WRKSRC}/examples/news.php.net/*.php ${EXAMPLESDIR}
-.endif
-.if !defined(NOPORTDOCS)
- @${MKDIR} ${DOCSDIR}
- @${INSTALL_DATA} ${WRKSRC}/examples/news.php.net/${PORTDOCS} ${DOCSDIR}
-.endif
-
.include <bsd.port.post.mk>
Index: net/pear-Net_NNTP/pkg-plist
===================================================================
RCS file: /home/ncvs/ports/net/pear-Net_NNTP/pkg-plist,v
retrieving revision 1.4
diff -u -u -r1.4 pkg-plist
--- net/pear-Net_NNTP/pkg-plist 5 Dec 2003 17:39:37 -0000 1.4
+++ net/pear-Net_NNTP/pkg-plist 12 Apr 2004 23:06:20 -0000
@@ -1,13 +0,0 @@
-%%PEARDIR%%/Net/NNTP.php
-%%PEARDIR%%/Net/NNTP/Header.php
-%%PEARDIR%%/Net/NNTP/Message.php
-%%PEARDIR%%/Net/NNTP/Protocol.php
-%%PEARDIR%%/Net/NNTP/Realtime.php
-%%PKGREGDIR%%/package.xml
-%%PORTEXAMPLES%%%%EXAMPLESDIR%%/read.php
-%%PORTEXAMPLES%%%%EXAMPLESDIR%%/group.php
-%%PORTEXAMPLES%%%%EXAMPLESDIR%%/index.php
-%%PORTEXAMPLES%%@dirrm %%EXAMPLESDIR%%
-@dirrm %%PEARDIR%%/Net/NNTP
-@dirrm %%PKGREGDIR%%
-@unexec rmdir %D/share/pear/Net 2> /dev/null || true
--- net-pear-Net_NNTP.FILES.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040413162457.6C7B72FDA01>