From owner-freebsd-ports@freebsd.org Fri Mar 17 22:08:50 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7F79D10D12 for ; Fri, 17 Mar 2017 22:08:50 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from anoxia.adamw.org (anoxia.adamw.org [104.225.8.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anoxia.adamw.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5043E1918 for ; Fri, 17 Mar 2017 22:08:49 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by anoxia.adamw.org (OpenSMTPD) with ESMTPSA id 3f0af139 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 17 Mar 2017 16:08:48 -0600 (MDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: foswiki fails to install From: Adam Weinberger In-Reply-To: Date: Fri, 17 Mar 2017 16:08:47 -0600 Cc: freebsd-ports@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <21EFFF09-CDFC-48A0-9681-ED87EAE33183@adamw.org> References: To: Chris H X-Mailer: Apple Mail (2.3259) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2017 22:08:50 -0000 > On 17 Mar, 2017, at 15:33, Chris H wrote: >=20 > On Fri, 17 Mar 2017 19:15:19 +0000 Doug Sampson = wrote >=20 >> I'm trying to install a fresh instance of www/foswiki version 2.1.3 = and it's >> failing as follows:=20 >>=20 >> root@draco:/usr/ports/www/foswiki # make install clean >> =3D=3D=3D> Patching for foswiki-2.1.3 >> =3D=3D=3D> Applying FreeBSD patches for foswiki-2.1.3 >> File to patch: >> No file found--skip this patch? [n] y >> 1 out of 1 hunks ignored--saving rejects to Oops.rej >> =3D> FreeBSD patch patch-minifycss failed to apply cleanly. >> *** Error code 1 >>=20 >> Stop. >> make[1]: stopped in /usr/ports/www/foswiki >> *** Error code 1 >>=20 >> Stop. >> make: stopped in /usr/ports/www/foswiki >> root@draco:/usr/ports/www/foswiki # >>=20 >> What's up? Why would I need to apply patch(es) when installing for = the first >> time?=20 > There are frequently patches required to install > software from the ports tree. Whether a first-time install, > or an upgrade. > In *this* case, however; I submitted pr(1) 217342, that > upgraded www/foswiki from 1.1.9 -> 2.1.3. The svn diff I > provided, *deleted* 2 files (patches) that were needed in > version 1.1.9, but not in version 2.1.3. However, the > deleted patches weren't reflected in the merge (commit) > 435357. I became aware of this shortly after the commit, > and opened a new pr(1) -- 217759, to address the issue. > But no one has responded. > In the short-term, you can simply delete the following > two files within the www/foswiki port: > files/patch-minifycss > files/patch-minifyjs >=20 > and the port will install as intended. I can't > explain why the files still show up, after the commit. > They should have been deleted. >=20 > HTH >=20 > --Chris Fixed in r436351. FWIW, when a PR contains a patch that deletes a file, = it's best if you add a reminder in the description. It's so easy to hit = 'rm' instead of 'svn rm'. # Adam --=20 Adam Weinberger adamw@adamw.org https://www.adamw.org