From owner-cvs-all@FreeBSD.ORG Thu Feb 3 19:18:23 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A1711065670 for ; Thu, 3 Feb 2011 19:18:23 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id A5E198FC12 for ; Thu, 3 Feb 2011 19:18:22 +0000 (UTC) Received: (qmail 16236 invoked by uid 399); 3 Feb 2011 19:18:22 -0000 Received: from localhost (HELO doug-optiplex.ka9q.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Feb 2011 19:18:22 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4D4AFF7C.5080006@FreeBSD.org> Date: Thu, 03 Feb 2011 11:18:20 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20110129 Thunderbird/3.1.7 MIME-Version: 1.0 To: Vsevolod Stakhov References: <201102021540.p12FewoY012116@repoman.freebsd.org> In-Reply-To: <201102021540.p12FewoY012116@repoman.freebsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, az@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail Makefile ports/mail/rspamd Makefile distinfo pkg-descr pkg-plist ports/mail/rspamd/files redirector.sh.in rspamd.sh.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2011 19:18:23 -0000 Couple of problems with the rc.d scripts. The biggest problem is that new scripts should not be added with the .sh extension. So, pointy hat to az@ on that one. :) For the redirector script: We prefer that the name of the file, $name, and PROVIDE all match. So since this file has to be renamed anyway, it should be renamed to rspamd_redirector.in (and the corresponding change made in USE_RC_SUBR of course). Also, you're not supposed to set procname directly. You should just set command= at the top. For the rspamd script: Same procname problem, otherwise it looks fine. hth, Doug On 02/02/2011 07:40, Vsevolod Stakhov wrote: > vsevolod 2011-02-02 15:40:58 UTC > > FreeBSD ports repository > > Modified files: > mail Makefile > Added files: > mail/rspamd Makefile distinfo pkg-descr pkg-plist > mail/rspamd/files redirector.sh.in rspamd.sh.in > Log: > Add rspamd - fast and modular spam filtering system written in C > in event driven paradigma. > > Reviewed by: az > Feature safe: yes > > Revision Changes Path > 1.1057 +1 -0 ports/mail/Makefile > 1.1 +72 -0 ports/mail/rspamd/Makefile (new) > 1.1 +2 -0 ports/mail/rspamd/distinfo (new) > 1.1 +33 -0 ports/mail/rspamd/files/redirector.sh.in (new) > 1.1 +52 -0 ports/mail/rspamd/files/rspamd.sh.in (new) > 1.1 +5 -0 ports/mail/rspamd/pkg-descr (new) > 1.1 +32 -0 ports/mail/rspamd/pkg-plist (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/Makefile.diff?&r1=1.1056&r2=1.1057&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/Makefile > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/distinfo > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/files/redirector.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/files/rspamd.sh.in > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/pkg-descr > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/rspamd/pkg-plist > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/