From owner-svn-src-head@freebsd.org Tue Oct 27 04:19:45 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE3D8A0654A; Tue, 27 Oct 2015 04:19:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8446F1AA6; Tue, 27 Oct 2015 04:19:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8ECD6B918; Tue, 27 Oct 2015 00:19:43 -0400 (EDT) From: John Baldwin To: Andrey Chernov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289863 - head/lib/libc/stdio Date: Mon, 26 Oct 2015 21:19:26 -0700 Message-ID: <2076950.skSTJcjGfc@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; ) In-Reply-To: <562EBD7F.6090009@freebsd.org> References: <201510240223.t9O2NFiY011536@repo.freebsd.org> <2119048.oF1gNjmV7i@ralph.baldwin.cx> <562EBD7F.6090009@freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 27 Oct 2015 00:19:43 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 04:19:45 -0000 On Tuesday, October 27, 2015 02:55:43 AM Andrey Chernov wrote: > On 26.10.2015 20:27, John Baldwin wrote: > > On Saturday, October 24, 2015 02:23:15 AM Andrey A. Chernov wrote: > >> Author: ache > >> Date: Sat Oct 24 02:23:15 2015 > >> New Revision: 289863 > >> URL: https://svnweb.freebsd.org/changeset/base/289863 > >> > >> Log: > >> Since no room left in the _flags, reuse __SALC for O_APPEND. > >> It helps to remove _fcntl() call from _ftello() and optimize seek position > >> calculation in _swrite(). > > > > You could just add a _flags2 to FILE if that would be cleaner. It should even > > be MFC'able without being an ABI change since stdio always allocates FILE > > objects internally and we only export pointers to them. Programs do not > > allocate them statically. > > > > Thanx, I understand it from your bugzilla answer, but I have a doubt. > What if some 3rd party port will use static FILE f; and then &f? Some of > ports may deal with FILE internals and I don't know which ones. I prefer > rather to not break something there and currently I need only one flag > and __SALC is not conflicting since used only with _file = -1 and > __SSTR. If you or somebody else will need another flag and be brave > enough to add _flags2, this patch can be easily converted. A static FILE f has never worked. Even in libc we have a special macro to initialize internal static FILE objects. Not too long ago (6.x?) we used to have a separate xFILE structure in a parallel array of extended fields. The only reason was that stdout/err/in resolved to offsets in a global array. Peter fixed those to indirect individual pointers, so we merged xFILE back into FILE. We've basically broken any software using static FILE f multiple times. It is true that some ports may abuse FILE internals, but they mostly do it via the macros in stdio.h, not directly. -- John Baldwin