From owner-svn-src-all@freebsd.org Mon Feb 25 19:15:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFB9915135BA for ; Mon, 25 Feb 2019 19:15:47 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2AB3F757F3 for ; Mon, 25 Feb 2019 19:15:46 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1551122104; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=qOJ7E4XvghZYUHb8vYR3eyTBdHjZBj9px2Epp6Zf7WVBbTT/i4xkWI3SqlWsVXzu/uCQ5aSs8Dp9y Y2lcOx7ti3apIHmqA/oiuAvcAN2MrGhY/3NxPERgfyeIbHE79oJuyjHkpb7k3z4aD/Dmz/qgYazJVx AfeNVPJfNf468EiXCxwf2Fhzh92Sxz4upEd29pqyZX9Sw52vXt49U3j01MvqSuQZAlSpjHv+9+eLGk FPfCMHx49GVqLT/TBpy2kymkd5c1tYqaWM//uNCyqTeVJ+ECzkfkCFAkgp2tLd1H1FkQPbFBEz4w5+ YTU9RAIsndBdTRJLNgTHK1CUOZ3xmyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=SVtzVl/sHxQ2hSqyxeoaq/OqpSvBl0rWyQXnE7hygyo=; b=g8uhm+Rc1d3uVero6z3af7oD6g68rXdZ2hmFw/WSUb+bzeLu39kBo6//Jkq0ow0act+U5w60NuWBi P8b8xlFClJHjsvLTtBXTToSGXajjdXK8HXPR0AsFTp4KyomDCTTnH4U4UQITdLWp3Oysa9+Zad3BNU J8hHlB0lIahKwvbLPXCzcyXlZqvDifzsWhJdEseeV/K26adhWpz4ZHWx775k38iNoGWrE2l70zonHN keXoFYQzLlcZYNawG5WaqfFYfYxeKVzDBbDFhLPys1fbAIDG5RQRcvK78NPPssfHpVcllwPW2PtwxJ KaS/C3HPNc199cBoGgt5eRTYDFu4IlA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=SVtzVl/sHxQ2hSqyxeoaq/OqpSvBl0rWyQXnE7hygyo=; b=aGOvU5SrQf5iWjhxRT4v2qlMNZjOjV3AQ3Zf8iGrpZbpno0z956plJ510xCIsiCSyJC8L6JoRMUBo f3VYQyWi1Or/HjOWtr24b5Im5e9jLpvIxmS0RYKGkJIjgyBeWnrfc6+e/NyR8QGL84nhUQtHmwqKyE YoHUNLCEQzYVeN3wfAk7CFyHLXqcYgSK6yGknSZslJnToAoX+NNxXmojdfi94rOYOqq7WtxDDK8vmw abWefSapkthZ8uZpxC/86tXprEncH9gnN2kx4pkom04bkUzULXslic8tQkdTlDjzca6AHoET17SZrT yzLcpRIFlOdBagtUvhWA1sEMhX+xWvQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: a6ab6441-3931-11e9-9789-75353a1f43cf X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id a6ab6441-3931-11e9-9789-75353a1f43cf; Mon, 25 Feb 2019 19:15:03 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x1PJFcnv099415; Mon, 25 Feb 2019 12:15:38 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r344534 - head/cddl/contrib/opensolaris/tools/ctf/cvt From: Ian Lepore To: luporl Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 25 Feb 2019 12:15:38 -0700 In-Reply-To: References: <201902251852.x1PIqlf7034853@repo.freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2AB3F757F3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.982,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 19:15:48 -0000 Nope, editing prior history is administratively disabled in the svn repo. But at least the commit message did include a reference to the review, so someone can dig up the info if they need it. -- Ian On Mon, 2019-02-25 at 16:10 -0300, luporl wrote: > Sorry, I forgot to copy the summary from D19353. > > Is there a way to change it now? > > On Mon, Feb 25, 2019 at 3:56 PM Ian Lepore wrote: > > > > On Mon, 2019-02-25 at 18:52 +0000, Leandro Lupori wrote: > > > Author: luporl > > > Date: Mon Feb 25 18:52:47 2019 > > > New Revision: 344534 > > > URL: https://svnweb.freebsd.org/changeset/base/344534 > > > > > > Log: > > > Increase ctfconvert buffer size > > > > > > Reviewed by: markj > > > Differential Revision: https://reviews.freebsd.org/D19353 > > > > > > > This is not a very good commit message. To be good, it should say > > why > > the size is being increased. If the commit had included the summary > > text from D19353 it would have been perfect. > > > > -- Ian > > > > > Modified: > > > head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > > > > > Modified: head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c > > > ================================================================= > > > ==== > > > ========= > > > --- head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon > > > Feb > > > 25 18:41:16 2019 (r344533) > > > +++ head/cddl/contrib/opensolaris/tools/ctf/cvt/dwarf.c Mon > > > Feb > > > 25 18:52:47 2019 (r344534) > > > @@ -1268,7 +1268,7 @@ die_funcptr_create(dwarf_t *dw, Dwarf_Die > > > die, > > > Dwarf_O > > > static intr_t * > > > die_base_name_parse(const char *name, char **newp) > > > { > > > - char buf[100]; > > > + char buf[256]; > > > char const *base; > > > char *c; > > > int nlong = 0, nshort = 0, nchar = 0, nint = 0; > > > > >