Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jun 2018 07:42:40 +0200
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        Eitan Adler <eadler@FreeBSD.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r334557 - head/usr.bin/top
Message-ID:  <20180604054240.bgzlzftyw2zaxwa4@ivaldir.net>
In-Reply-To: <201806031341.w53DfOAD000819@repo.freebsd.org>
References:  <201806031341.w53DfOAD000819@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--47aaiunxce7kltcf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 03, 2018 at 01:41:24PM +0000, Eitan Adler wrote:
> Author: eadler
> Date: Sun Jun  3 13:41:23 2018
> New Revision: 334557
> URL: https://svnweb.freebsd.org/changeset/base/334557
>=20
> Log:
>   top(1): restore size for kern.cp_times
>  =20
>   Restore last minute change that broke top(1).
>=20
> Modified:
>   head/usr.bin/top/machine.c
>=20
> Modified: head/usr.bin/top/machine.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/usr.bin/top/machine.c	Sun Jun  3 13:40:58 2018	(r334556)
> +++ head/usr.bin/top/machine.c	Sun Jun  3 13:41:23 2018	(r334557)
> @@ -384,6 +384,7 @@ machine_init(struct statics *statics)
>  	times =3D calloc(maxcpu * CPUSTATES, sizeof(long));
>  	if (times =3D=3D NULL)
>  		err(1, "calloc %zu bytes", size);
> +	size =3D sizeof(long) * maxcpu * CPUSTATES;

The error message just above might also be unhappy about the size variable =
:)

Bapt

--47aaiunxce7kltcf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlsU0U4ACgkQY4mL3PG3
Plpq6xAAtIRPO2DilEFq4krvWJE7QNdZv97h3l7c4v5M8KhVSXD07JMRHnXC4NKv
wKRhrRpTCIYF111a+1Fy4l6HGove+APmColQGC29eSnreusElHSWvhFXgNP58x9M
T7a07/a2w2VJ91uhvQUa4ekfbLUl3maqqovozcms7zNa1eGDvutDPdIvgbSS6z1F
vS8XQfa+OD1fL7BBTIG+HnusmDnYRgT3jU9RuKWkI4HMGiFuzqRgpB38PfhNGwsQ
qK8bxm5Rkf+kr3FuLwZ0SBR/epN4Y73HLEtebKRtdq33bxQ62UEHGqanV9gJtk7q
C5mR29i5fshlCAK+Ie79oo5V3EwsORX/bVFOVp8Invi7V2RPq7tqnN2uEVs7VUP2
xm/zDM41ESO33D73Ncp58lRmKJGJcuLgw8dvpwd2X+JnKfS1yButcre2g9QBdeui
dZ2vUsLWXrIv/ydgVoGCh3lt2Bi6mz3e52E6Gh77aBfjjQVwlD2hpiC31Kid/Z7o
CcCStBOmPraxna64H++8oYxitRCHz9uiVKpEOpZ5zYf5/OG4t5AXeH8ehPUxFwvY
tJYLILQbpyt58PRzhSZmbrEMXl7e9h+ytb+ALPwIbbSsbI6M1iu5uGJZdcfrn+dC
gSdFyf8hVfNCx5F2p+QUQphy2XRoPuHnWueWaNpghlfWa91Mli0=
=+vS+
-----END PGP SIGNATURE-----

--47aaiunxce7kltcf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180604054240.bgzlzftyw2zaxwa4>