From owner-freebsd-ports@FreeBSD.ORG Wed Sep 20 01:26:00 2006 Return-Path: X-Original-To: freebsd-ports@freebsd.org Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 592BE16A403 for ; Wed, 20 Sep 2006 01:26:00 +0000 (UTC) (envelope-from sailorfred@yahoo.com) Received: from web31806.mail.mud.yahoo.com (web31806.mail.mud.yahoo.com [68.142.207.69]) by mx1.FreeBSD.org (Postfix) with SMTP id 58E1643D5F for ; Wed, 20 Sep 2006 01:25:50 +0000 (GMT) (envelope-from sailorfred@yahoo.com) Received: (qmail 92111 invoked by uid 60001); 20 Sep 2006 01:25:50 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=NVceilH/2IyABva+Piv6grL9/hghSrjQ30wC25lTPugQsiQ2Bo3yGlcrEabWBWizFqDaYaMIqvxhezH7332mTrKWWDbAZECaRFeVmt4jtHcrzaxclo1XeXgOU8c4IyCxY/PO588g8Z5P0tCFRX3x3dE1utHN8NZ0ALBomMll+Vg= ; Message-ID: <20060920012550.92109.qmail@web31806.mail.mud.yahoo.com> Received: from [64.18.7.193] by web31806.mail.mud.yahoo.com via HTTP; Tue, 19 Sep 2006 18:25:50 PDT Date: Tue, 19 Sep 2006 18:25:50 -0700 (PDT) From: Fred Cox To: Kris Kennaway In-Reply-To: <20060920011215.GA51890@xor.obsecurity.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: freebsd-ports@freebsd.org, Kris Kennaway Subject: Re: www/dotproject out of date and vulnerable X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2006 01:26:00 -0000 --- Kris Kennaway wrote: > On Tue, Sep 19, 2006 at 06:02:52PM -0700, Fred Cox > wrote: > > --- Kris Kennaway wrote: > > > > > On Tue, Sep 19, 2006 at 05:15:45PM -0700, Fred > Cox > > > wrote: > > > > > > > Actually, it doesn't. It goes ahead and > installs > > > it, > > > > even though I specified these: > > > > > > > > WITH_MYSQL= yes > > > > WANT_MYSQL_VER= 323 > > > > IGNORE_WITH_MYSQL=5 > > > > > > > > Starting with a system that had no MySQL or > PHP > > > > installed on it, I did a make install in the > > > > dotproject port with the Makefile and distinfo > I > > > > specified earlier. > > > > > > > > It seems to look for mysql.so, and if that's > > > found, it > > > > doesn't worry about the version. > > > > > > OK, so it's just silently broken, which is > worse. > > > > > > > It's still better than the current situation. > > Publishing packages that will not run because > they're linked to the > wrong libraries is, again, not my idea of "better". > There is no linkage problem. It's a client/server problem. PHP4 is perfectly happy being linked with the MySQL 5 client libraries, it's the database server that needs to be 3.23. The SQL used in dotProject is legal for 3.23, but not 5. > > > > See the log at http://fcox.net/dp.log, when no > > > mysql > > > > or php was installed on the system. > > > > > > > > Perhaps this is a bug in the dependencies > system. > > > > > > Dunno without investigating. Anyway, the > correct > > > solution is the > > > same. > > > > > > > OK, so if you had a pointer on how to depend on > that > > alternate version, it would help. > > Copy the php4-mysql port to php4-mysql3 and make the > presumably > trivial change to make it use mysql 3 instead of > whatever the default > is. > It's not trivial. The current Makefile is trivial, but a change to do what you're suggesting will need to be more complex. Here's the current php4-mysql Makefile: CATEGORIES= databases MASTERDIR= ${.CURDIR}/../../lang/php4 PKGNAMESUFFIX= -mysql .include "${MASTERDIR}/Makefile" The ${MASTERDIR}/Makefile doesn't refer to mysql at all. Personally, I don't see how it knows it's supposed to link MySQL in there. Perhaps it's because PHP4 defaults to including MySQL support, so this isn't really doing anything. I haven't read far enough to know for sure. > > Right now, the > > dependencies are specified with the WITH and > IGNORE > > variables, but it seems that with your proposal I > > won't be able to do that. Maybe tonight I will > fall > > asleep reading the Porter's Handbook. > > OK. > > Kris > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com