From owner-cvs-src@FreeBSD.ORG Wed Jul 2 10:23:46 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 29F8137B404; Wed, 2 Jul 2003 10:23:45 -0700 (PDT) Received: from critter.freebsd.dk (port757.uc1-esp.isdn-lan.cybercity.dk [212.242.98.245]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82F7A43F85; Wed, 2 Jul 2003 10:23:44 -0700 (PDT) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h62HNdDj002250; Wed, 2 Jul 2003 19:23:40 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Nate Lawson From: "Poul-Henning Kamp" In-Reply-To: Your message of "Wed, 02 Jul 2003 10:20:53 PDT." <20030702101716.E90143@root.org> Date: Wed, 02 Jul 2003 19:23:39 +0200 Message-ID: <2249.1057166619@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_nfsiod.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jul 2003 17:23:47 -0000 In message <20030702101716.E90143@root.org>, Nate Lawson writes: >On Wed, 2 Jul 2003, Poul-Henning Kamp wrote: >> Change idle sleep indentifier to "-" for nfsiod >> >> Revision Changes Path >> 1.78 +1 -1 src/sys/nfsclient/nfs_nfsiod.c > >I'm ok with changing to a single character for the default sleep state but >"-" is the same as a running process. For example: > > 1000 90138 90136 2 18 0 1780 1364 pause Ss p0 0:00.10 -tcsh > 1000 90210 90138 2 28 0 440 196 - R+ p0 0:00.00 ps axl > >As you can see, without looking at the run field, it doesn't immediately >jump out at you which processes are asleep where the "pause" above >definitely does. How about something like "+" or "*"? ...but as you can see, the sleeping processes lack the (R)unning flag. I don't care one iota what the string is, I simple went with '-' because the interrrupt threads already used that. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.