From owner-cvs-all@FreeBSD.ORG Wed Dec 10 01:09:40 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B52991065672; Wed, 10 Dec 2008 01:09:40 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id 5A5058FC14; Wed, 10 Dec 2008 01:09:40 +0000 (UTC) (envelope-from sobomax@sippysoft.com) Received: from [192.168.1.38] (S0106001372fd1e07.vs.shawcable.net [70.71.171.106]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id mBA19cvQ087319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 9 Dec 2008 17:09:39 -0800 (PST) (envelope-from sobomax@sippysoft.com) Message-ID: <493F16B1.3020409@sippysoft.com> Date: Tue, 09 Dec 2008 17:09:05 -0800 From: Maxim Sobolev Organization: Sippy Software User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: pav@FreeBSD.ORG References: <200812090602.mB962eiw090973@repoman.freebsd.org> <20081209191509.GA50518@FreeBSD.org> <493ED4B6.4010409@sippysoft.com> <1228858485.917.4.camel@hood.oook.cz> In-Reply-To: <1228858485.917.4.camel@hood.oook.cz> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8bit Cc: cvs-ports@FreeBSD.ORG, Alexey Dokuchaev , cvs-all@FreeBSD.ORG, ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/net/asterisk Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2008 01:09:40 -0000 Pav Lucistnik wrote: > Maxim Sobolev píše v út 09. 12. 2008 v 12:27 -0800: > >>>> sobomax 2008-12-09 06:02:40 UTC >>>> >>>> FreeBSD ports repository >>>> >>>> Modified files: >>>> net/asterisk Makefile >>>> Log: >>>> Convert all WITHOUT_XXX options into WITH_XXX form. OPTIONS system >>>> only really supports the latter. >>> I've always been under impression that OPTIONS support both. Can you >>> please point to bpm/bom revisions where it was broken? >> Maybe I did not make myself clear, by "not supported" I have meant that >> in BATCH mode the mk is not automatically generating WITHOUT_XXX >> definitions for the items that are supposed to be off by default. You >> can get more details in the PR mentioned in the commit message. > > Not true since bsd.port.mk rev. 1.559, I think. OK, further investigation shows that it doesn't happen to OPTIONS added after .include : Today's ports (1.604 of bsd.port.mk), FreeBSD/amd64,: [sobomax@pioneer ~]$ cd /usr/ports/net/asterisk [sobomax@pioneer /usr/ports/net/asterisk]$ sudo rm -rf /var/db/ports [sobomax@pioneer /usr/ports/net/asterisk]$ make -DBATCH -V WITHOUT_ZAPTEL [sobomax@pioneer /usr/ports/net/asterisk]$ make -DBATCH -V WITHOUT_ILBC true The difference is that ZAPTEL is defined after .include : ----- OPTIONS= OGGVORBIS "Enable Ogg Vorbis support" on \ ODBC "Enable ODBC support" on \ POSTGRES "Enable PostgreSQL support" on \ RADIUS "Enable RADIUS accounting support" on \ SNMP "Enable SNMP support" on \ H323 "Enable H.323 support" on \ FREETDS "Enable FreeTDS support" on \ JABBER "Enable Jabber and Gtalk support" on \ SQLITE "Enable SQLITE support" on \ CODEC_PATCH "Apply codec negotiation patch" off \ ILBC "Enable iLBC codec" off \ MISC_PATCHES "Apply additional patches" off .include .if ${ARCH} == "i386" || ${ARCH} == "amd64" OPTIONS+= ZAPTEL "Enable Zaptel support" off .endif ----- Looks like a bug in bsd.port.mk to me. -Maxim