From owner-freebsd-bluetooth@FreeBSD.ORG Fri Nov 7 21:20:23 2008 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5387B1065692 for ; Fri, 7 Nov 2008 21:20:23 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from megatron.madpilot.net (megatron.madpilot.net [88.149.173.206]) by mx1.freebsd.org (Postfix) with ESMTP id E5AE18FC0A for ; Fri, 7 Nov 2008 21:20:22 +0000 (UTC) (envelope-from mad@madpilot.net) Received: from localhost (localhost [127.0.0.1]) by megatron.madpilot.net (Postfix) with ESMTP id 23AD0130C08; Fri, 7 Nov 2008 22:20:22 +0100 (CET) X-Virus-Scanned: amavisd-new at madpilot.net Received: from megatron.madpilot.net ([127.0.0.1]) by localhost (megatron.madpilot.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jh3MVaTXUgdl; Fri, 7 Nov 2008 22:20:19 +0100 (CET) Received: from anakin.madpilot.net (anakin.madpilot.net [172.24.42.10]) by megatron.madpilot.net (Postfix) with ESMTP; Fri, 7 Nov 2008 22:20:19 +0100 (CET) Message-ID: <4914B113.60303@madpilot.net> Date: Fri, 07 Nov 2008 22:20:19 +0100 From: Guido Falsi User-Agent: Thunderbird 2.0.0.17 (X11/20080927) MIME-Version: 1.0 To: Iain Hibbert References: <20081104111947.GB62907@megatron.madpilot.net> <1225799105.807983.1164.nullmailer@galant.ukfsn.org> <20081104135107.GA64776@megatron.madpilot.net> <1225821264.107584.759.nullmailer@galant.ukfsn.org> <4910B6E6.7070206@madpilot.net> <4910CA97.6030708@madpilot.net> <1226091521.039371.399.nullmailer@galant.ukfsn.org> In-Reply-To: <1226091521.039371.399.nullmailer@galant.ukfsn.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-bluetooth@freebsd.org Subject: Re: RFComm behaviour with nokia mobiles X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2008 21:20:23 -0000 Iain Hibbert wrote: > On Tue, 4 Nov 2008, Guido Falsi wrote: > >> Guido Falsi wrote: >> >>> As I said, that was my mistake. Anyway I thank you a lot because you gave me >>> the idea where to look for mistakes. I should be able to get gnokii to work >>> now. Thank you a lot again! >> I've just submitted a PR for the gnokii port. If someone feels like checking >> my work(it does need checking I think) it's here: > > The attribute ID list should be in ascending order according to the > specification. This means though that some logic could be wrong because > the protocol descriptor list for any given service class would likely > appear before the service name in the response attribute list and you > would use the wrong channel.. Uhm, I did not get this detail in the specification. > > probably you should do it like: > > channel = -1; > > switch (attribute) { > case PROTOCOL_DESCRIPTOR_LIST > channel = <...>; > break; > > case SERVICE_NAME > if (channel == -1) > break; > > str = <...>; > > if (strncmp(str, "...")) { > channel = -1; > break; > } > > return success; > } > > ? I'll check it. > > also, instead of providing two calls to the find_service_channel() > function, just put > > #ifdef SDP_SERVICE_CLASS_SERIAL_PORT > #define SERIAL_PORT_SVCLASS_ID SDP_SERVICE_CLASS_SERIAL_PORT > #endif > > at the top which cuts down on unreadable alternatives? Gnokii author also required this before importing the patch upstream, so I've already fixed this. The original software also has some glue functions put there for compatibility which are not needed, so I'm going to remove them. can you or Maksim confirm FreeBSD has always had(expecially in 6.x) bt_aton(), str2ba() and bacpy() ? -- Guido Falsi