From owner-freebsd-cvsweb@FreeBSD.ORG  Thu Oct 14 00:14:10 2004
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C648C16A4CE
	for <freebsd-cvsweb@freebsd.org>;
	Thu, 14 Oct 2004 00:14:10 +0000 (GMT)
Received: from ms-smtp-02-eri0.ohiordc.rr.com
	(ms-smtp-02-smtplb.ohiordc.rr.com [65.24.5.136])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 45AB443D53
	for <freebsd-cvsweb@freebsd.org>;
	Thu, 14 Oct 2004 00:14:10 +0000 (GMT)	(envelope-from rfrancis@ev.net)
Received: from [192.168.0.2] (dhcp065-024-145-058.columbus.rr.com
	[65.24.145.58])i9E0E7Jl022757	for <freebsd-cvsweb@freebsd.org>;
	Wed, 13 Oct 2004 20:14:08 -0400 (EDT)
Message-ID: <416D8C45.8060303@ev.net>
Date: Wed, 13 Oct 2004 20:12:53 +0000
From: Russell Francis <rfrancis@ev.net>
User-Agent: Mozilla Thunderbird 0.7.1 (X11/20040710)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: freebsd-cvsweb@freebsd.org
X-Enigmail-Version: 0.85.0.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed;
 boundary="------------040808060201080906070809"
X-Virus-Scanned: Symantec AntiVirus Scan Engine
Subject: [BUG] download link doesn't work if path has spaces.
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Oct 2004 00:14:10 -0000

This is a multi-part message in MIME format.
--------------040808060201080906070809
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

I am using CVSweb 3.0.1 and discovered that if any file contained in a
CVS module has a space character in it's path, the download link will
fail to download the file.  The attached patch seems to fix the problem
but I am not very familiar with CVSweb so it is really more of a shot in
the dark.

If you allready know about this issue, I appologize for repeating it.

Thanks,
Russ

--------------040808060201080906070809
Content-Type: text/plain;
 name="cvsweb.cgi.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="cvsweb.cgi.diff"

--- cvsweb.cgi.backup	Wed Oct 13 19:08:18 2004
+++ cvsweb.cgi	Wed Oct 13 19:55:23 2004
@@ -4106,6 +4106,7 @@
   if (!defined($mimetype) || $mimetype !~ CVSWEBMARKUP) {
     my $path = $where;
     $path =~ s|[^/]+$||;
+    $path =~ s/ /%20/g;
     $url = "$scriptname/$CheckoutMagic/${path}$url";
   }
   $url .= '?rev=' . uri_escape($revision);

--------------040808060201080906070809--