Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Jun 2006 13:25:30 -0500
From:      Alan Cox <alc@cs.rice.edu>
To:        John Baldwin <jhb@freebsd.org>
Cc:        cvs-src@freebsd.org, John-Mark Gurney <gurney_j@resnet.uoregon.edu>, src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org>, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/lib/libc/sys mincore.2 src/sys/vm vm_mmap.c
Message-ID:  <44998F1A.3020208@cs.rice.edu>
In-Reply-To: <200606211413.24602.jhb@freebsd.org>
References:  <200606211259.k5LCx5as082227@repoman.freebsd.org> <44998562.6080705@cs.rice.edu> <20060621175821.GB82074@funkthat.com> <200606211413.24602.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:

>On Wednesday 21 June 2006 13:58, John-Mark Gurney wrote:
>  
>
>>Alan Cox wrote this message on Wed, Jun 21, 2006 at 12:44 -0500:
>>    
>>
>>>John-Mark Gurney wrote:
>>>
>>>      
>>>
>>>>Konstantin Belousov wrote this message on Wed, Jun 21, 2006 at 12:59 
>>>>        
>>>>
>+0000:
>  
>
>>>>>Modified files:
>>>>>  lib/libc/sys         mincore.2 
>>>>>  sys/vm               vm_mmap.c 
>>>>>Log:
>>>>>Make the mincore(2) return ENOMEM when requested range is not fully 
>>>>>mapped.
>>>>>          
>>>>>
>>>>Is this change to be posix compliant or something?  ENOMEM seems like
>>>>the wrong error, or are we allocating memory?
>>>>#define ENOMEM          12              /* Cannot allocate memory */
>>>>
>>>>the original EINVAL seems to me the correct one, as is commonly used
>>>>when the data passed in is incorrect...
>>>>        
>>>>
>>>I looked at this when the patch was proposed.  ENOMEM is the de facto 
>>>standard error for this case.  To the best of my knowledge, there is no 
>>>officially-sanctioned specification for mincore(2).
>>>      
>>>
>>Could you please provide a reference to this de facto standard error
>>as in other places where ENOMEM is used for such an error?
>>    
>>
>
>NetBSD and Linux were the examples given on the thread in hackers@.  Check the 
>archives.
>
>  
>
You can add AIX and Solaris to that list.  Every system that I found 
that supports mincore(2) returns ENOMEM in this case.

Alan




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44998F1A.3020208>