From owner-svn-src-all@FreeBSD.ORG Sun Mar 22 23:42:32 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 845071065677 for ; Sun, 22 Mar 2009 23:42:32 +0000 (UTC) (envelope-from silby@silby.com) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.freebsd.org (Postfix) with SMTP id 249A48FC15 for ; Sun, 22 Mar 2009 23:42:31 +0000 (UTC) (envelope-from silby@silby.com) Received: (qmail 28058 invoked from network); 22 Mar 2009 23:15:50 -0000 Received: from 209.68.2.70 (HELO localhost) (209.68.2.70) by relay01.pair.com with SMTP; 22 Mar 2009 23:15:50 -0000 X-pair-Authenticated: 209.68.2.70 Date: Sun, 22 Mar 2009 18:15:49 -0500 (CDT) From: Mike Silbersack To: Robert Watson In-Reply-To: Message-ID: References: <200903222300.n2MN00IO086771@svn.freebsd.org> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-stable-7@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Mike Silbersack , src-committers@freebsd.org Subject: Re: svn commit: r190299 - stable/7/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2009 23:42:33 -0000 On Sun, 22 Mar 2009, Robert Watson wrote: > On Sun, 22 Mar 2009, Mike Silbersack wrote: > >> Fix unp_gc so that it recognizes file descriptors >> that are currently in the process of being passed >> between processes as alive and does not >> try to garbage collect them. >> >> The full description of the problem and a test >> program to reproduce it can be found in PR 112554. >> >> This fix was inspired by similar fixes in NetBSD and BSD/OS. >> However, it does not apply to FreeBSD 8 and above - >> when this code was rewritten and optimized, the bug >> was fixed in a different way. The test program in the >> PR passes on 8-current with flying colors. > > We have a UNIX domain socket-passing regression test that creates various > contortion-esque situations and then looks to see if sockets were leaked. If > it doesn't yet capture this failure mode, could you add it to that test? > > Robert N M Watson > Computer Laboratory > University of Cambridge I've been meaning to do that for two years, that's what delayed me from committing this. I finally decided to get it in before I missed another release. So I can try, but I won't make any guarantees. Mike "Silby" Silbersack