From owner-freebsd-ports@FreeBSD.ORG Thu Aug 10 13:21:10 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF17816A508; Thu, 10 Aug 2006 13:21:10 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1E32843D46; Thu, 10 Aug 2006 13:21:09 +0000 (GMT) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net ([12.207.12.9]) by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP id <20060810132108m92002tea0e>; Thu, 10 Aug 2006 13:21:08 +0000 Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.6/8.13.6) with ESMTP id k7ADL6lx020321; Thu, 10 Aug 2006 08:21:07 -0500 (CDT) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.6/8.13.6/Submit) id k7ADL6iX020320; Thu, 10 Aug 2006 08:21:06 -0500 (CDT) (envelope-from brooks) Date: Thu, 10 Aug 2006 08:21:05 -0500 From: Brooks Davis To: John E Hein Message-ID: <20060810132105.GA20275@lor.one-eyed-alien.net> References: <17626.25183.846983.515718@gromit.timing.com> <17626.25444.563099.956775@gromit.timing.com> <44DA6FC9.3040404@FreeBSD.org> <17626.29481.909830.326948@gromit.timing.com> <17626.30422.650339.960580@gromit.timing.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: <17626.30422.650339.960580@gromit.timing.com> User-Agent: Mutt/1.5.11 Cc: ports@freebsd.org, G?bor K?vesd?n Subject: Re: support for DESTDIR: security/openssh-portable X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Aug 2006 13:21:10 -0000 --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 09, 2006 at 05:59:18PM -0600, John E Hein wrote: > John E Hein wrote at 17:43 -0600 on Aug 9, 2006: > > Well, the part that makes it annoying to duplicate in all ports is not > > the two separate words (CHROOT DESTDIR), but that you have to test > > defined(DESTDIR) && !empty(DESTDIR) before you can figure out whether > > to use ${CHROOT} ${DESTDIR} or not. > >=20 > > So having that test to assign CHROOTDESTDIR or leave it empty in > > bsd.port.mk allows the port writer to just always invoke it without > > having to worry about testing for DESTDIR. >=20 > You could pass this var to pkg-install scripts, too (put it in the > standard *SUB* lists). >=20 > That way you don't have to do the dance that was added to > security/clamav/files/pkg-install.in: >=20 > if [ -n "%%DESTDIR%%" ]; then > PW=3D"/usr/sbin/chroot %%DESTDIR%% pw" > CHOWN=3D"/usr/sbin/chroot %%DESTDIR%% chown" > MKDIR=3D"/usr/sbin/chroot %%DESTDIR%% mkdir -p" > else > PW=3D"pw" > CHOWN=3D"chown" > MKDIR=3D"mkdir -p" > fi >=20 > but rather just: >=20 > PW=3D"%%CHROOTDESTDIR%% pw" > CHOWN=3D"%%CHROOTDESTDIR%% chown" > MKDIR=3D"%%CHROOTDESTDIR%% mkdir -p" This seems bogus. I can't think of any good reason why packages should differ based on the valid of DESTDIR. Instead the pkg-install script should be run inside the chroot. -- Brooks --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFE2zLBXY6L6fI4GtQRAsoKAJ4zGboa3aSEChiazcCjyLUOvkX2awCffsCZ CLtJmz7B7B8pnnPDuvjtX1Y= =vyCC -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--