From owner-freebsd-bugs@FreeBSD.ORG  Wed Jun 18 08:20:04 2003
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3D4B737B412
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Jun 2003 08:20:04 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C967043FBD
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 18 Jun 2003 08:20:02 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h5IFK2Up036579
	for <freebsd-bugs@freefall.freebsd.org>;
	Wed, 18 Jun 2003 08:20:02 -0700 (PDT)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h5IFK2HQ036578;
	Wed, 18 Jun 2003 08:20:02 -0700 (PDT)
Resent-Date: Wed, 18 Jun 2003 08:20:02 -0700 (PDT)
Resent-Message-Id: <200306181520.h5IFK2HQ036578@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	arc <arc@a5r.highway.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 96A3037B401
	for <FreeBSD-gnats-submit@freebsd.org>;
	Wed, 18 Jun 2003 08:13:00 -0700 (PDT)
Received: from vm01.highway.ne.jp (vm01.highway.ne.jp [210.166.100.50])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3503F43F85
	for <FreeBSD-gnats-submit@freebsd.org>;
	Wed, 18 Jun 2003 08:12:59 -0700 (PDT)
	(envelope-from arc@a5r.highway.ne.jp)
Received: (qmail 10744 invoked from network); 19 Jun 2003 00:12:57 +0900
Received: from unknown (HELO mtpro) (210.249.196.142)
  by vm01.highway.ne.jp with SMTP; 19 Jun 2003 00:12:57 +0900
Message-Id: <4.0.1-J.20030619001619.02053a38@vm01.highway.ne.jp>
Date: Thu, 19 Jun 2003 00:20:05 +0900
From: arc <arc@a5r.highway.ne.jp>
To: FreeBSD-gnats-submit@FreeBSD.org
Subject: misc/53450: [patch] Cvsweb 2.0.6 or above cause an error
	withwhite-space included  directory
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Jun 2003 15:20:04 -0000


>Number:         53450
>Category:       misc
>Synopsis:       [patch] Cvsweb 2.0.6 or above cause an error with white-space inc
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 18 08:20:02 PDT 2003
>Closed-Date:
>Last-Modified:
>Originator:     arc aka heno <arc@a5r.highway.ne.jp>
>Release:        FreeBSD 4.5-RELEASE i386
>Organization:
program-bbs@2ch
>Environment:
System: FreeBSD fr45 4.5-RELEASE FreeBSD 4.5-RELEASE #0: Mon Jan 28 14:31:56
 GMT 2002 murray@builder.freebsdmall.com:/usr/src/sys/compile/GENERIC i386

 and sourceforge.jp (Linux)

>Description:
FreeBSD-cvsweb says an error when "(download)" link was clicked for files in
 a directory named with white-space.

  like:
    "ncvs/white\ space\ included\ directory/try-to-download-this,v"

>How-To-Repeat:

FreeBSD-cvs 2.0.6
ttp://minix-up.sourceforge.jp/cgi-bin/now.cgi/l/t%20c/try-to-download-this

Fixed
ttp://minix-up.sourceforge.jp/cgi-bin/fixed.cgi/l/t%20c/try-to-download-this


>Fix:

--- now.cgi	Sun Jun 15 12:48:28 2003
+++ fixed.cgi	Sun Jun 15 12:46:38 2003
@@ -3410,6 +3410,7 @@
 	{
 		my $path = $where;
 		$path =~ s|[^/]+$||;
+		$path = urlencode($path);
 		$url = "$scriptname/$checkoutMagic/${path}$url";
 	}
 	$url .= "?rev=$revision";


>Release-Note:
>Audit-Trail:
>Unformatted:
 luded  directory