From owner-cvs-src@FreeBSD.ORG Fri Jun 22 21:35:59 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E9C1316A421 for ; Fri, 22 Jun 2007 21:35:59 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id 807BD13C465 for ; Fri, 22 Jun 2007 21:35:59 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 67386 invoked from network); 22 Jun 2007 17:24:15 -0000 Received: from ppp-71-139-42-13.dsl.snfc21.pacbell.net (HELO ?10.0.0.15?) (nate-mail@71.139.42.13) by root.org with ESMTPA; 22 Jun 2007 17:24:15 -0000 Message-ID: <467C05B8.6090105@root.org> Date: Fri, 22 Jun 2007 10:24:08 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.0 (X11/20070511) MIME-Version: 1.0 To: Kostik Belousov References: <200706212250.l5LMobq4038270@repoman.freebsd.org> <20070622034555.GD2268@deviant.kiev.zoral.com.ua> In-Reply-To: <20070622034555.GD2268@deviant.kiev.zoral.com.ua> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/etc devd.conf rc.resume rc.suspend src/sys/i386/acpica acpi_machdep.c src/usr.sbin/acpi/acpiconf acpiconf.c src/sys/dev/acpica acpi.c acpiio.h acpivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2007 21:36:00 -0000 Kostik Belousov wrote: > On Thu, Jun 21, 2007 at 10:50:37PM +0000, Nate Lawson wrote: >> njl 2007-06-21 22:50:37 UTC >> >> FreeBSD src repository >> >> Modified files: >> etc devd.conf rc.suspend rc.resume >> sys/i386/acpica acpi_machdep.c >> usr.sbin/acpi/acpiconf acpiconf.c >> sys/dev/acpica acpi.c acpiio.h acpivar.h >> Log: >> Update the suspend/resume user API while maintaining backwards compat. >> >> Improvements: >> * /dev/apm is clonable, allowing multiple listeners for suspend events. > Did you evaluate/tested destroy_dev_sched() KPI for your needs ? Comments on your patch coming via private email. > I do not see any protection for several opens going parallel on given cdev. > I.e., I think that si_drv1 assignment in open() could cause problems. > Generally, as I know, system does not enforce any serialization between > calls to cdev methods for mp-safe drivers. Right, something your patch doesn't implement that we need is for SI_CHEAPCLONE to really mean "no export to devfs". -- Nate