From owner-freebsd-ports Thu Aug 19 17:12:43 1999 Delivered-To: freebsd-ports@freebsd.org Received: from news-ma.rhein-neckar.de (news-ma.rhein-neckar.de [193.197.90.3]) by hub.freebsd.org (Postfix) with ESMTP id 9B6071526D for ; Thu, 19 Aug 1999 17:12:37 -0700 (PDT) (envelope-from naddy@bigeye.rhein-neckar.de) Received: from mips.rhein-neckar.de (uucp@localhost) by news-ma.rhein-neckar.de (8.8.8/8.8.8) with bsmtp id CAA08827; Fri, 20 Aug 1999 02:11:56 +0200 (CEST) (envelope-from naddy@bigeye.rhein-neckar.de) Received: from bigeye.rhein-neckar.de ([193.197.90.235]) by mips.rhein-neckar.de with esmtp id m11HcEf-000WyPC (Debian Smail-3.2.0.101 1997-Dec-17 #2); Fri, 20 Aug 1999 02:08:45 +0200 (CEST) Received: (from naddy@localhost) by bigeye.rhein-neckar.de (8.9.3/8.9.3) id CAA85994; Fri, 20 Aug 1999 02:10:42 +0200 (CEST) (envelope-from naddy) Date: Fri, 20 Aug 1999 02:10:42 +0200 (CEST) From: Christian Weisgerber Message-Id: <199908200010.CAA85994@bigeye.rhein-neckar.de> To: kbyanc@posi.net, freebsd-ports@freebsd.org Subject: Re: ports/13259: new port: editors/bvi In-Reply-To: <199908192141.RAA51208@kronos.alcnet.com> Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org In article <199908192141.RAA51208@kronos.alcnet.com> you write: > >Synopsis: new port: editors/bvi Objections: - The port ignores CFLAGS. - The dependency on ncurses is pointless; ncurses is part of the base system. Those are trivial to fix, but there is a much more serious problem: - When I took a look at bvi 1.2.0beta some time ago, it blew up into my face, because the code was written with the assumption sizeof(off_t) == sizeof(long), which is wrong for all 32-bit BSD machines (but not Linux). Getting rid of this will require some work. The old version 1.1.1 this port uses doesn't know off_t at all. The author simply uses long for file position/length throughout. Also, he mostly uses K&R function definitions, i.e. no prototypes, which means you're not going to get much in the way of automatic casts. This doesn't bode well for the 32/64-bit conflicts. Kelly, how much testing have you given this port? After about one minute, I can already tell you that saving a file will append a garbage byte to it. I suggest that the port not be committed at this time. -- Christian "naddy" Weisgerber naddy@mips.rhein-neckar.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message