From owner-p4-projects@FreeBSD.ORG Sun Apr 23 21:43:39 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 50EE716A40A; Sun, 23 Apr 2006 21:43:39 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 28AF316A407 for ; Sun, 23 Apr 2006 21:43:39 +0000 (UTC) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5132443D5C for ; Sun, 23 Apr 2006 21:43:38 +0000 (GMT) (envelope-from jb@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k3NLhcVX001131 for ; Sun, 23 Apr 2006 21:43:38 GMT (envelope-from jb@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k3NLhc7F001128 for perforce@freebsd.org; Sun, 23 Apr 2006 21:43:38 GMT (envelope-from jb@freebsd.org) Date: Sun, 23 Apr 2006 21:43:38 GMT Message-Id: <200604232143.k3NLhc7F001128@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to jb@freebsd.org using -f From: John Birrell To: Perforce Change Reviews Cc: Subject: PERFORCE change 95955 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Apr 2006 21:43:39 -0000 http://perforce.freebsd.org/chv.cgi?CH=95955 Change 95955 by jb@jb_freebsd2 on 2006/04/23 21:43:32 Now that the dtrace device supports cloning, it doesn't actually need to create a base device at all. In fact, the way that FreeBSD's device cloning works, if /dev/dtrace is actually created, then cloning fails. Cloning was only working when the base device was created as /dev/dtrace0, but it turns out that was just being ignored when dtrace(1) opened /dev/dtrace. So now we have a stealth device. To open it, you just have to trust it's there. 8-) Affected files ... .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace.c#12 edit .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_load.c#7 edit .. //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_unload.c#6 edit Differences ... ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace.c#12 (text+ko) ==== @@ -90,9 +90,6 @@ .d_name = "dtrace", }; -/* For use with make_dev(9)/destroy_dev(9). */ -static struct cdev *dtrace_dev; - /* * DTrace Tunable Variables * ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_load.c#7 (text+ko) ==== @@ -56,10 +56,6 @@ dtrace_mutex_init(&dtrace_provider_lock,"dtrace provider state"); dtrace_mutex_init(&dtrace_meta_lock,"dtrace meta-provider state"); - /* Create the /dev/dtrace entry. */ - dtrace_dev = make_dev(&dtrace_cdevsw, DTRACE_MINOR, UID_ROOT, - GID_WHEEL, 0660, "dtrace0"); - mutex_enter(&cpu_lock); mutex_enter(&dtrace_provider_lock); mutex_enter(&dtrace_lock); ==== //depot/projects/dtrace/src/sys/cddl/dev/dtrace/dtrace_unload.c#6 (text+ko) ==== @@ -146,9 +146,6 @@ dtrace_taskq = NULL; #endif - /* Destroy the /dev/dtrace entry. */ - destroy_dev(dtrace_dev); - dtrace_mutex_destroy(&dtrace_meta_lock); dtrace_mutex_destroy(&dtrace_provider_lock); dtrace_mutex_destroy(&dtrace_lock);