Date: Fri, 31 Aug 2012 11:13:01 +0200 From: deeptech71@gmail.com To: Dimitry Andric <dimitry@andric.com> Cc: freebsd-current@FreeBSD.org Subject: Re: sys/dev/amr build error with Clang Message-ID: <5040801D.9090305@gmail.com> In-Reply-To: <50407947.50907@andric.com> References: <504068F2.6010300@gmail.com> <50407947.50907@andric.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Dimitry Andric wrote: > The one call to get the callout to amr_periodic() started seems to have > been commented out in r239912: > > http://svnweb.freebsd.org/base/head/sys/dev/amr/amr.c?r1=239912&r2=239911&pathrev=239912 > > If the function isn't necessary anymore, it could just be deleted, or > #ifdef'd out. I don't use "amr", so I personally don't care whether the use of the function was accidentally commented out or whether the function was accidentally left unused. But on a side-note, to a programmer not familiar with the driver, that case seems like a case of "the use was accidentally commented out".
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5040801D.9090305>