Date: Fri, 13 Jul 2007 14:39:51 +0200 From: "Attilio Rao" <attilio@freebsd.org> To: "Craig Boston" <craig@yekse.gank.org>, "Juergen Lock" <nox@jelal.kn-bremen.de>, attilio@freebsd.org, freebsd-emulation@freebsd.org, freebsd-ports@freebsd.org Subject: Re: experimental qemu-devel port update, please test! Message-ID: <3bbf2fe10707130539q5d74fd86w55dfb20254cd4255@mail.gmail.com> In-Reply-To: <20070712180750.GB77654@nowhere> References: <20070702203027.GA45302@saturn.kn-bremen.de> <46925324.9010908@freebsd.org> <3bbf2fe10707091140h6cdc7469nac5be03a8c8a60cb@mail.gmail.com> <200707092000.29768.dfr@rabson.org> <200707092149.l69LnXe9023835@saturn.kn-bremen.de> <20070712175252.GA77654@nowhere> <20070712180750.GB77654@nowhere>
next in thread | previous in thread | raw e-mail | index | archive | help
2007/7/12, Craig Boston <craig@yekse.gank.org>: > On Thu, Jul 12, 2007 at 12:52:52PM -0500, Craig Boston wrote: > > For some reason when the ioctl is issued, curproc points to a totally > > bogus proc structure. curthread seems to be sane as far as I can tell, > > but the process it claims to belong to is full of junk. > > Aha! The problem isn't that curproc is garbage, but rather that it's > being interpreted wrong. > > struct proc has some extra fields when KSE is #defined. KSE recently > became a kernel option and was put in the DEFAULTS file, so everyone's > kernel has it defined. But kqemu is being compiled without it. > > I compiled with -DKSE and now kqemu works! Ok, this patch should make this behaviour no more conditioned to KSE presence or not: http://people.freebsd.org/~attilio/kqemu.diff Note: this is highly untested due to lack of time and stuffs, but it should work. You would test in all the 4 configuration: - kernel with KSE, kqemu without - kernel without KSE, kquemu without - kernel with KSE, kqemu with - kernel without KSE, kquemu without They should all work. If they doesn't please let me know. An alternative approach would be to just not making KSE stuffs conditional, but even if I hate these ABI breakages I hate even more adding 16 unused bytes to "struct thread" struct on amd64. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10707130539q5d74fd86w55dfb20254cd4255>