From owner-cvs-all@FreeBSD.ORG  Fri May 30 10:15:57 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2088A37B401; Fri, 30 May 2003 10:15:57 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C595A43F3F; Fri, 30 May 2003 10:15:56 -0700 (PDT)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h4UHFu0U053820;
	Fri, 30 May 2003 10:15:56 -0700 (PDT)
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h4UHFueR053819;
	Fri, 30 May 2003 10:15:56 -0700 (PDT)
Message-Id: <200305301715.h4UHFueR053819@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Fri, 30 May 2003 10:15:56 -0700 (PDT)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/nfsclient nfs_lock.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 30 May 2003 17:15:57 -0000

rwatson     2003/05/30 10:15:56 PDT

  FreeBSD src repository

  Modified files:
    sys/nfsclient        nfs_lock.c 
  Log:
  rpc.lockd stability workaround: remove PCATCH from the tsleep() in
  nfs_lock.c.  Right now, if we permit a signal to interrupt the sleep,
  we will slip the lock and no process on that client, the server, or
  any other client will be able to acquire the lock.  This can happen,
  for example, if a user hits Ctrl-C or Ctrl-T while a process is
  waiting for the lock.  By removing PCATCH, we prevent that from
  happening, at the cost of not permitting a user-requested lock abort:
  also nasty.  However, a user interface bug might be preferable to a
  serious semantic bug, so we go with that for now.
  
  We need to teach the rpc.lockd/kernel protocol how to abort lock
  requests, and rpc.lockd how to handle aborted lock requests; patches
  for the kernel bit are floating around, but no rpc.lockd bit yet.
  
  Approved by:    re (scottl)
  
  Revision  Changes    Path
  1.36      +1 -1      src/sys/nfsclient/nfs_lock.c