From owner-freebsd-current@freebsd.org Mon Jun 27 11:55:37 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1896DB840B3; Mon, 27 Jun 2016 11:55:37 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com [IPv6:2a00:1450:400c:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9E35E2D01; Mon, 27 Jun 2016 11:55:36 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x234.google.com with SMTP id a66so111701390wme.0; Mon, 27 Jun 2016 04:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WiWx8x4/lp4jrP21DKIpwkgbtmUhf8eUpB6WQ1rjGSs=; b=fgeQPOvmTwezIKEWDF7UJN4LsQDBPFP9/vk4LonEAEI15Tvkq6UvGSAzJlNEgf9i90 7yPAGJBurFGjHII7KW1U8OJV/ATedP8rtsfnZUSnKDlPRSg1l/f/780wL+sVxjqBwMfQ f/f2j2RXVqLUcbJ19g1jApngSTewvoYFuRRg9iGieuuqJoqVUV3CqLhUB2MXpt4uXg5r sUq7s5jgEWDy+C5ut4U6Lj/XS7s1k7R3iWAby/0aCBPsuCahKNFla3ywYFdMxrsNgPk+ WtIeT0ffPkffvE2DNRTtM27dpmHaBO+ep+bRxEBRdMIFsWHrErvfdPniHQudjfBcThKg 5MpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=WiWx8x4/lp4jrP21DKIpwkgbtmUhf8eUpB6WQ1rjGSs=; b=bHANb1QFtsNa7Lfg34kr5U9F4zkadM4HpCv8du2ukL9LY6ovsOVsU3vMTYebMYcQNC SfgebKfAb1anDmYn3WxdteqskI2GU6xF5dmUjl+vVqA6XDb1H0rZ8/sISJQyOswhbhRD ltHiWRzWvO7LNTFXJ/x7VaxkHp5uO+pfX8sfHOhgRxsvU6q/0FqiVduYJLlOzj6kQmXe UX/aLzsB5bZ9ec+L91+hPBBohJgzH0uNKfitpCVxceimiHfLAzlfGt/iG28jiiTvLyc3 tQuqfkMRlX0iWO7MUiKOvEdtWt2naWRXbRgO+jbSo7wNLRSbZbOlsjhHpMJ4Is/KMFrg yuqQ== X-Gm-Message-State: ALyK8tLxU9G+N8mvqvmnK0KquBP389XmHiluudeoUSri4XgHTvbqAzOrFQ2dmD8wF1CM/Q== X-Received: by 10.28.145.68 with SMTP id t65mr9705470wmd.31.1467028535239; Mon, 27 Jun 2016 04:55:35 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id h8sm1191459wjg.9.2016.06.27.04.55.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 04:55:34 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 27 Jun 2016 13:55:33 +0200 From: Baptiste Daroussin To: Hans Petter Selasky Cc: Slawa Olhovchenkov , ports@FreeBSD.org, FreeBSD Current Subject: Re: pkg SAT_SOLVER bugs Message-ID: <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r5fafvid2ollsvjd" Content-Disposition: inline In-Reply-To: <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> User-Agent: Mutt/1.6.1-neo (2016-06-11) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 11:55:37 -0000 --r5fafvid2ollsvjd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 27, 2016 at 12:38:02PM +0200, Hans Petter Selasky wrote: > Hi, >=20 > I found some bugs in PKG with regard to the SAT_SOLVER environment variab= le. > Please find patch attached :-) >=20 > Issues fixed: > 1) No need to use hash table when generating SAT rules for external solve= r. > Variables are already in a linear array. Fix encoding and decoding of SAT > data. > 2) Endless variable loop caused pkg to crash. > 3) it->inverse was checked for non-zero, while it should actually be chec= ked > for -1 only. SAT rules produces were all negative. >=20 > How to verify: >=20 > make -C /usr/ports/math/picosat all install clean >=20 > env SAT_SOLVER=3Dpicosat pkg upgrade >=20 > --HPS Thank you I will look into shortly Best regards, Bapt --r5fafvid2ollsvjd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXcRQyAAoJEGOJi9zxtz5aIZkQAMJQv1kj+AAHPKvaT8L+tO21 Xr3BruHii53Q5BSIbccAb3rx2atPbziXJ/JWS4HfVpVUJ2hz2i1Z6hpD+krVt8Jg IXZnXzgIbaFbM/unDrTob3lEkn5/M6wTaFN7cUIMTR98ECDVhqMonEOZcr9rRFMp yE+W0CAlF5LKoLmMYML2tuDQnfW9Lkr8qkM1Ik0ag5uecX7u7JszO39dAnEM9Zph H9jtIWfHhaEmRqiJJ/gbHfcSo5fskvLF0TfdBlwytVjCM9vhXJO525pofEmcS8Y/ eZYXC6Rb/jFA20c7Xf4YoIo8AZEok419vF6GsfcVPQvSEBSDFrEq0fTdFgjq3DGh haJYtnaNA6EUf6p0Sb5ZEaJZtXUG46P/zY99LUTLXeP1KOkY3CnWxPuycdE4s5ej JShFs8ONwCOrJMabSuzsdisCXL2KWazsZKzJVdEIBQy5sblYHBiUoiphwLeJmkoL 50B7xqv4SFFpdEvGYLGxjZBI0yGQJWWmyH+vL/thjfuIOW+ubNu8pNiNtuiL/O4S tfkpXDTBEiY3OfLfybkm7mUpfpg/eV3nFo56IkGB6RhaM+gGK0d+5Hmu1lzg+Ur8 e4qpJcNJ9a0DOg9C6akstkGhBNISaz1mwMJJTo8OWleZaVQqSC9BvJZc3vpGfchQ PmrCeFdzRbaF2Ief6Mhu =MeX6 -----END PGP SIGNATURE----- --r5fafvid2ollsvjd--