From owner-svn-src-head@FreeBSD.ORG Tue Sep 21 16:39:25 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 450C8106566B; Tue, 21 Sep 2010 16:39:25 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id D27838FC18; Tue, 21 Sep 2010 16:39:24 +0000 (UTC) Received: by iwn34 with SMTP id 34so6290787iwn.13 for ; Tue, 21 Sep 2010 09:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=iS54kzfIqBUJsHBxBHUNE8PMibdZlpIJn7H+KMWpncc=; b=lij3ZEZH/lg/yKo4GJM4OJiYP5mIP4BgCk/SBzFyUOOfsrmABd3JrpB6NlBWZA+cP7 cPFrlBK9rSMBszObyWxxAKu3/O2N+AFFFIEpdocfKjQJ/PiyrejBp0p0h6txNmfKu3hL G7rA23cmqSciiQ9+I/i2VUkaJx+RJwH17L/qU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=svfNcT03iegdHQKEG5gbl4C0Xljjy+vY1+DZz62rdwnDdj8PyZh2fbcSU/yJaWaDHB FRnNP3QA7oWivLJ7bcARxQLyZBL4wWTJNlGGfZfyRH891ioXMDbfnxKklOSgsFXqLF7i QHWZcG/hMVwOvqH1BGIUfPTNuoIGP6zqNx+Ns= MIME-Version: 1.0 Received: by 10.231.14.69 with SMTP id f5mr12171599iba.116.1285087164009; Tue, 21 Sep 2010 09:39:24 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.231.187.71 with HTTP; Tue, 21 Sep 2010 09:39:23 -0700 (PDT) In-Reply-To: <4C98DF25.9040100@freebsd.org> References: <201009211507.o8LF7iVv097676@svn.freebsd.org> <4C98CEE7.6060802@freebsd.org> <4C98D200.4040909@freebsd.org> <4C98DF25.9040100@freebsd.org> Date: Tue, 21 Sep 2010 09:39:23 -0700 X-Google-Sender-Auth: ZaQ2kyv0dIdaqyR_6NR_dbVx1gc Message-ID: From: mdf@FreeBSD.org To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212964 - head/sys/kern X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Sep 2010 16:39:25 -0000 On Tue, Sep 21, 2010 at 9:36 AM, Andriy Gapon wrote: > on 21/09/2010 19:31 mdf@FreeBSD.org said the following: >> I keep forgetting, but actually _mtx_lock_sleep() will just return if >> panicstr is set. =A0_mtx_assert() is similarly guarded, so actually it >> should be mostly okay. > > But this doesn't seem to be the case for sx lock which is wrapped under K= LD_LOCK() ? Right, that was it. I knew I hit a problem on 7 in the past. The right thing is probably to guard the sx_[sx]lock_hard primitives and sx_assert in the same way. Thanks, matthew