From owner-freebsd-current@freebsd.org Tue Jul 5 19:29:42 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA5E5B215FD for ; Tue, 5 Jul 2016 19:29:42 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x230.google.com (mail-pf0-x230.google.com [IPv6:2607:f8b0:400e:c00::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 76AA117CE; Tue, 5 Jul 2016 19:29:42 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x230.google.com with SMTP id h14so72642254pfe.1; Tue, 05 Jul 2016 12:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=77i9FrZmF3LM9B2RB05ImI/W1kvq6yCy3fgF2l9snyU=; b=BsyJ44FvTi1CWe7VOQTenDy290URlmv1YPOfg51pG2xGosqRBAaDvNYJ7okch/PfFu F5AXws5Mha6SO+tm0y4oWnu4kj8oZrhSP9btHPVpymaYRKlTjX7TKjWrfMptlJW82LEd syGhG3Tb9VG6g6vy9SYOGXsUwGtTR57wUVzyAa8LNU5OQ4iJpeVz5Wz8HdGeFyPRI27w QxuLCFo3D/FOigwX/woLeKOqDR0vkRMLjaJ3GsHrbTR1nQ8DhmZxYkoGSBeomdCoaMtm Ruacrepcrw4hjmVg1PR7EKoCFM1RUruC20CcXx3oMw15IQn9W32xjsxGMlMkjtmFWUUr 7+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=77i9FrZmF3LM9B2RB05ImI/W1kvq6yCy3fgF2l9snyU=; b=jqeZ5bsnhchUOZY8h3mk3dZ3axw58D6TDJQoEFhHv7nFKNw4AKozb2o0v+w+cRoAif ATSHmOUbgXC6ohI3S6C3+vCCuU//cRF/rWBDf17kpyb2o0qT9SZbJVdmSmzS9vynT0Wf s/DcNNaW/5qzrjGISmuoDtTy6w4qlOo5FPlIw0eJ2pKvyiQn6OPjIiQqGDGfelVBu0q7 h6CFsLMp5RWbNYRN/tMox3A1aRV6QwgmecZlIqGyjGPdA0n+7OsbMBh4GiSaECOR1wO8 a92aYVhTgScqNdp5e4jQQkpVX/CCrfHMly2E/FC6tK3PepcgqzIdRL2yT69ZBWVcExe5 cn/Q== X-Gm-Message-State: ALyK8tJj98cdAkeO+aYIg/y1vPOslESx1wr0Cf5wCOwgc7lc7ng+2HLM8yfGdRPKtFV7sw== X-Received: by 10.98.131.206 with SMTP id h197mr34578658pfe.124.1467746981914; Tue, 05 Jul 2016 12:29:41 -0700 (PDT) Received: from [192.168.20.18] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n124sm6812334pfn.44.2016.07.05.12.29.40 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Jul 2016 12:29:40 -0700 (PDT) Subject: Re: FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_E4C496E1-3356-4098-9594-CC25AFE06DC2"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.6b2 From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Tue, 5 Jul 2016 12:29:39 -0700 Cc: freebsd-current@FreeBSD.org, Roman Divacky Message-Id: References: <74935894.29.1467723929184.JavaMail.jenkins@jenkins-9.freebsd.org> <824400089.31.1467734600930.JavaMail.jenkins@jenkins-9.freebsd.org> <1A4CCE99-7039-404C-B177-1DA230AD8811@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 19:29:42 -0000 --Apple-Mail=_E4C496E1-3356-4098-9594-CC25AFE06DC2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jul 5, 2016, at 11:54, Ngie Cooper (yaneurabeya) = wrote: >=20 >>=20 >> On Jul 5, 2016, at 11:52, Dimitry Andric wrote: >>=20 >> On 05 Jul 2016, at 18:03, jenkins-admin@freebsd.org wrote: >>>=20 >>> FreeBSD_HEAD_amd64_gcc - Build #1340 - Still Failing: >>>=20 >>> Build information: = https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/ >>> Full change log: = https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/changes >>> Full build log: = https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_amd64_gcc/1340/console >> ... >>> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c: In function = 'sse42_supported': >>> /builds/FreeBSD_HEAD_amd64_gcc/usr.sbin/bhyve/rfb.c:885:17: error: = 'bit_SSE42' undeclared (first use in this function) >>> return ((ecx & bit_SSE42) !=3D 0); >>> ^ >>=20 >> So, this is because clang's and gcc's versions of cpuid.h use = slightly different naming for these bits: >>=20 >> clang's cpuid.h: >>=20 >> #define bit_SSE41 0x00080000 >> #define bit_SSE42 0x00100000 >>=20 >> gcc's cpuid.h: >>=20 >> #define bit_SSE4_1 (1 << 19) >> #define bit_SSE4_2 (1 << 20) >>=20 >> Unfortunately there are more bit defines that differ. No = standardization on this point, it seems. :-/ >>=20 >> For this specific compile error, we could put in a little crutch = like: >>=20 >> #if defined(bit_SSE4_2) && !defined(bit_SSE42) >> #define bit_SSE42 bit_SSE4_2 >> #endif >>=20 >> Thoughts? >=20 > Seems ok to me. I was going to submit a patch to fix the other = issues with bhyve (because I am getting annoyed by the build failure = emails). Actually, there=E2=80=99s a better #define: /usr/include/x86/specialreg.h:#define CPUID2_SSE41 0x00080000 Thanks, -Ngie --Apple-Mail=_E4C496E1-3356-4098-9594-CC25AFE06DC2 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXfAqkAAoJEPWDqSZpMIYVBEsQAIGbME5jpV3Z1/dITibrNZ/l TiYCCMEIcnw3VA/YguDOVicCVGwqVuuRmmjjukubb/JqyADjSlOUa22etzjGqp56 95kxoAFLxdqOC/2f0CsqNTMd39TWdwqRBKeqQjs1AJQQImqLYZzBnJRpzR1QsKaP eXtSENoF4u0uSKwOaj2p4ugmoN5OhqNJzr5XpTSHE71G+/9yH9VSCFldPKmlVa9k yJhFVIUdxSvH2R5+3K6IQ+9JQggk8wAWt3U6mmlrV4GEOQi1TtcPVHyUtaF/mXYK XFeeMeZ8iMNr+rhva7X9EBx/eGvHTb1X9DbiPjMx1BGBmO8a3bm7x0NLJGH1KO1K AZ6FpsOXVpRl6e5JxeMnUhN2ZuR+TazDi24nNT/5ryrmIwN8KIQhg6F+bzah9Jee iA2VstUOM4zSi7aXfVb50EGjC/Dysz80BGyjSaejfY/Uq1SkwOosC6WIFY+rRYVa I8SA2HVGrNbg3jTpSTFS4W5x1xBfUSiinSuQ50bzKyi+7sawhFFZ9UkQb+PB3Fyb H7L/2/Z75ZGhTWm2jN1vSbpyxSPMtGwESa+LmB71IdNnv9fVfxukGlDUfyQqAtRS r7prR7yyAcAQPnqmm82Ak/N5cE5NxsS6E3kyRZz4+eZ3IPD6QSqx3XdU0RwVF8wI 3d+IASf4KGn7VtBDa0ml =9xpV -----END PGP SIGNATURE----- --Apple-Mail=_E4C496E1-3356-4098-9594-CC25AFE06DC2--