Date: Mon, 12 Jan 2009 12:47:54 -0800 From: "Garrett Cooper" <yanefbsd@gmail.com> To: "Julian Elischer" <julian@elischer.org> Cc: "Li, Qing" <qing.li@bluecoat.com>, Gerald Pfeifer <gerald@pfeifer.com>, freebsd-net@freebsd.org, Qing Li <qingli@freebsd.org>, freebsd-current@freebsd.org, Tijl Coosemans <tijl@ulyssis.org> Subject: Re: HEADSUP: arp-v2 has been committed Message-ID: <7d6fde3d0901121247t31ee0d8cp6d46cf9b3b256fad@mail.gmail.com> In-Reply-To: <496BAA26.9010200@elischer.org> References: <20081227202117.F3B14341A3@cavin02.kulnet.kuleuven.ac.be> <200812281613.49404.tijl@ulyssis.org> <alpine.LSU.1.99.0812290925070.23595@acrux.dbai.tuwien.ac.at> <B583FBF374231F4A89607B4D08578A4302B1CAC5@bcs-mail03.internal.cacheflow.com> <alpine.LSU.1.99.0901091021370.12007@acrux.dbai.tuwien.ac.at> <B583FBF374231F4A89607B4D08578A4302CDB052@bcs-mail03.internal.cacheflow.com> <7d6fde3d0901121212i3acf282dj6bc3b7d59a044e5e@mail.gmail.com> <496BAA26.9010200@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 12, 2009 at 12:37 PM, Julian Elischer <julian@elischer.org> wrote:
> Garrett Cooper wrote:
>
> I think setting it to a value of 0 has two good points...
>
> In code that does:
> if (XXX & RTF_LLINFO) {
> yyy()
> }
> the optimiser should simply remove the code,
> or at worst give an error messages that makes people go look for
> the answer, and secondly,
> the conditional
>
> #if defined(RTF_LLINFO) && (RTF_LLINFO != 0)
>
> can be easily used to make code conditionally do the right thing
> for different versions of freeBSD,
> possibly trivially replacing earlier occurances of
>
> #ifdef RTF_LLINFO
>
>
>
>>
>> Oh, btw... wine works well when you set the RTF_LLINFO value to 0
>> with arp-v2, AFAICT.
>> -Garrett
That's basically what I did (2 instances in the file had to be replaced) --
#ifndef RTF_LLINFO
/* Insert code here with 0. */
#else
/* Insert code here with RTF_LLINFO. */
#endif
The code checks to see if sysctl exists, and then defaults to Linux-y
behavior, so other OS'es with proper sysctl support could be broken by
this change.
I tested this out with Steam and wine-doors, but unfortunately I ran
into OpenGL issues that prevented me from playing Steam games -_-...
Cheers,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7d6fde3d0901121247t31ee0d8cp6d46cf9b3b256fad>