From owner-svn-ports-all@freebsd.org Sun Feb 5 18:58:12 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F5F0CD26D9; Sun, 5 Feb 2017 18:58:12 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0C68D1C22; Sun, 5 Feb 2017 18:58:11 +0000 (UTC) (envelope-from jbeich@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v15IwBlO022472; Sun, 5 Feb 2017 18:58:11 GMT (envelope-from jbeich@FreeBSD.org) Received: (from jbeich@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v15IwB2I022471; Sun, 5 Feb 2017 18:58:11 GMT (envelope-from jbeich@FreeBSD.org) Message-Id: <201702051858.v15IwB2I022471@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jbeich set sender to jbeich@FreeBSD.org using -f From: Jan Beich Date: Sun, 5 Feb 2017 18:58:11 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r433445 - head/multimedia/kodi/files X-SVN-Group: ports-head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Feb 2017 18:58:12 -0000 Author: jbeich Date: Sun Feb 5 18:58:10 2017 New Revision: 433445 URL: https://svnweb.freebsd.org/changeset/ports/433445 Log: multimedia/kodi: unbreak with clang 4.0 RssReader.cpp:269:19: error: ordered comparison between pointer and zero ('TiXmlElement *' and 'int') while (itemNode > 0) ~~~~~~~~ ^ ~ RssReader.cpp:273:22: error: ordered comparison between pointer and zero ('TiXmlNode *' and 'int') while (childNode > 0) ~~~~~~~~~ ^ ~ PR: 216075 Submitted by: tcberner Approved by: maintainer timeout (2 weeks) Added: head/multimedia/kodi/files/patch-xbmc_utils_RssReader.cpp (contents, props changed) Added: head/multimedia/kodi/files/patch-xbmc_utils_RssReader.cpp ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/multimedia/kodi/files/patch-xbmc_utils_RssReader.cpp Sun Feb 5 18:58:10 2017 (r433445) @@ -0,0 +1,18 @@ +Fix bogus pointer comparisons. + +--- xbmc/utils/RssReader.cpp.orig 2017-01-21 21:11:51 UTC ++++ xbmc/utils/RssReader.cpp +@@ -266,11 +266,11 @@ void CRssReader::GetNewsItems(TiXmlEleme + if (m_tagSet.empty()) + AddTag("title"); + +- while (itemNode > 0) ++ while (itemNode) + { + TiXmlNode* childNode = itemNode->FirstChild(); + mTagElements.clear(); +- while (childNode > 0) ++ while (childNode) + { + std::string strName = childNode->ValueStr(); +