Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Feb 2016 15:54:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 206956] x11-wm/herbstluftwm: update to 0.7.0
Message-ID:  <bug-206956-13-uy43aIOxdS@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-206956-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-206956-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206956

--- Comment #3 from Raphael Kubo da Costa <rakuco@FreeBSD.org> ---
> Do you have any idea about tput warnings? Or are they important?

The tput warnings likely come from here:
https://github.com/herbstluftwm/herbstluftwm/blob/v0.7.0/colors.mk and are =
just
used for decorating the output of non-verbose builds. One quick way to get =
rid
of those warnings is to force a verbose build (i.e. add "VERBOSE=3D" to
MAKE_ARGS).

> And maybe it's enough to disable unrecognized command line options? I thi=
nk the -W* is okay, but what about -std=3Dc++11?

You are approaching this from the wrong point of view. While it could be
possible to remove the unrecognized warnings from the command line, you can=
not
rewrite the source code in C++98 instead of C++11. Upstream has made a choi=
ce
to use C++11 in its code, so you need to adapt the port to follow suit.

With that said, that's what we have USES=3Dcompiler for. USES=3Dcompiler:c+=
+11-lang
adds a build-time dependency on a compiler that understands C++11 (and
consequently the -std=3Dc++11 flag). It is not enough in this case, though,=
 since
the port also uses C++11 features from the standard library (such as the
<array> header). This means you need USES=3Dcompiler:c++11-lib instead.

Since we're talking about the port anyway, I have a few suggestions for you:
- Instead of doing LDXX=3Dc++ in the Makefile, LDXX=3D${CXX} is more flexib=
le.
- Keep an eye on what upstream does to the build system in the next release=
s: I
was checking
https://github.com/herbstluftwm/herbstluftwm/compare/v0.6.2...v0.7.0 to com=
ment
here, and it looks like they've started working on porting their build syst=
em
away from their home-baked solution to CMake. It's still experimental, but =
you
might want to consider switching to it in the future.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-206956-13-uy43aIOxdS>