Date: Wed, 20 Oct 2010 09:02:01 +0200 From: Paul B Mahol <onemda@gmail.com> To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bernhard Schmidt <bschmidt@freebsd.org> Subject: Re: svn commit: r214070 - head/sys/dev/if_ndis Message-ID: <AANLkTinc62z2R7A7XZ_%2BbOPFF-WExfuJcwuzJdzyLMbF@mail.gmail.com> In-Reply-To: <20101019220455.D46881@maildrop.int.zabbadoz.net> References: <201010191911.o9JJBaQe024210@svn.freebsd.org> <20101019220455.D46881@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/20/10, Bjoern A. Zeeb <bzeeb-lists@lists.zabbadoz.net> wrote: > On Tue, 19 Oct 2010, Bernhard Schmidt wrote: > >> Author: bschmidt >> Date: Tue Oct 19 19:11:36 2010 >> New Revision: 214070 >> URL: http://svn.freebsd.org/changeset/base/214070 >> >> Log: >> There is no reason to call rt_ifmsg(), remove it. > > While it's indeed very uncommon to have that in a driver, I don't know > how much black magic if_ndis(4) is. Have you verified that you still > get the events from elsewhere on the routing socket when > loading/unloading if_ndif.ko? ^if_ndis.ko If you want to ask if we got notified if wlan0 is put down/up or if we disconnected/associated and etc. then answer is yes and have nothing to do with unloading if_ndis but with miniport driver (generated via ndisgen). I unload/load ndis/if_ndis/miniport combo multiple times with/without loadi/unload of other drivers and did not encounter any regression when removing rt_ifmsg(). One more thing, currently when interface wlanX is bring up/down we will send events to ndisX instead, this caused breakdown with one of CURRENT revisions, but that revision was reverted later. Also, currently if user put wlan0 interface down(via ifconfig) we will get down event only after bringing same interface up. Both of this cases where not fixed with rt_ifmsg() call. I already have pach for both cases, and will send them to net@ shortly. If you have more time to review my code, please visit http://gitorious.org/NDISulator Comments are welcome. >> Submitted by: Paul B Mahol <onemda at gmail.com> >> MFC after: 1 week >> >> Modified: >> head/sys/dev/if_ndis/if_ndis.c >> >> Modified: head/sys/dev/if_ndis/if_ndis.c >> ============================================================================== >> --- head/sys/dev/if_ndis/if_ndis.c Tue Oct 19 18:49:26 2010 (r214069) >> +++ head/sys/dev/if_ndis/if_ndis.c Tue Oct 19 19:11:36 2010 (r214070) >> @@ -1644,10 +1644,6 @@ ndis_linksts_done(adapter) >> default: >> break; >> } >> - >> - /* Notify possible listners of interface change. */ >> - >> - rt_ifmsg(ifp); >> } >> >> static void >> > > -- > Bjoern A. Zeeb Welcome a new stage of life. > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinc62z2R7A7XZ_%2BbOPFF-WExfuJcwuzJdzyLMbF>