From owner-svn-src-head@FreeBSD.ORG Wed Oct 20 07:02:03 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93B8C1065674; Wed, 20 Oct 2010 07:02:03 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id C4EF88FC13; Wed, 20 Oct 2010 07:02:02 +0000 (UTC) Received: by wwb13 with SMTP id 13so2472023wwb.31 for ; Wed, 20 Oct 2010 00:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=J+0lDj/r1wYto3kLIB0WyC1l9G+3hLsYE4KaJhdWOKQ=; b=GM+2Qg7rpw6EnWtoAOfEsydb5E1g6nwrbi47FJN+7Kk6j0t+hIN/Xro/COoo+imqKQ d6Tnq56+NecClV4uECpsk0boCA3yryommmtOrVG1hGaQwt7tchhrQ4g6kWJN43ponVfI DCL8MInlPzK1mbss+v483NmjzjyHZ/OTHfeiM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=FVFqVYPUrG/0tlaJnBDn9bC1sK1mqkcCLm9o0ZFKghFOIxyCBxFRTBMRUECOFMg49n iupAEdi9B6Z7cVWE5wzonJHqVlyTvcI+jL3JAJ76C2IzfeL2cEbIIX8MI4eZpeks7gSL TdfDyEmhhr4nTxxU5hAakp+R85ZSAV7Z3Rt0Y= MIME-Version: 1.0 Received: by 10.216.16.85 with SMTP id g63mr7648469weg.114.1287558121482; Wed, 20 Oct 2010 00:02:01 -0700 (PDT) Received: by 10.216.183.146 with HTTP; Wed, 20 Oct 2010 00:02:01 -0700 (PDT) In-Reply-To: <20101019220455.D46881@maildrop.int.zabbadoz.net> References: <201010191911.o9JJBaQe024210@svn.freebsd.org> <20101019220455.D46881@maildrop.int.zabbadoz.net> Date: Wed, 20 Oct 2010 09:02:01 +0200 Message-ID: From: Paul B Mahol To: "Bjoern A. Zeeb" Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Bernhard Schmidt Subject: Re: svn commit: r214070 - head/sys/dev/if_ndis X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Oct 2010 07:02:03 -0000 On 10/20/10, Bjoern A. Zeeb wrote: > On Tue, 19 Oct 2010, Bernhard Schmidt wrote: > >> Author: bschmidt >> Date: Tue Oct 19 19:11:36 2010 >> New Revision: 214070 >> URL: http://svn.freebsd.org/changeset/base/214070 >> >> Log: >> There is no reason to call rt_ifmsg(), remove it. > > While it's indeed very uncommon to have that in a driver, I don't know > how much black magic if_ndis(4) is. Have you verified that you still > get the events from elsewhere on the routing socket when > loading/unloading if_ndif.ko? ^if_ndis.ko If you want to ask if we got notified if wlan0 is put down/up or if we disconnected/associated and etc. then answer is yes and have nothing to do with unloading if_ndis but with miniport driver (generated via ndisgen). I unload/load ndis/if_ndis/miniport combo multiple times with/without loadi/unload of other drivers and did not encounter any regression when removing rt_ifmsg(). One more thing, currently when interface wlanX is bring up/down we will send events to ndisX instead, this caused breakdown with one of CURRENT revisions, but that revision was reverted later. Also, currently if user put wlan0 interface down(via ifconfig) we will get down event only after bringing same interface up. Both of this cases where not fixed with rt_ifmsg() call. I already have pach for both cases, and will send them to net@ shortly. If you have more time to review my code, please visit http://gitorious.org/NDISulator Comments are welcome. >> Submitted by: Paul B Mahol >> MFC after: 1 week >> >> Modified: >> head/sys/dev/if_ndis/if_ndis.c >> >> Modified: head/sys/dev/if_ndis/if_ndis.c >> ============================================================================== >> --- head/sys/dev/if_ndis/if_ndis.c Tue Oct 19 18:49:26 2010 (r214069) >> +++ head/sys/dev/if_ndis/if_ndis.c Tue Oct 19 19:11:36 2010 (r214070) >> @@ -1644,10 +1644,6 @@ ndis_linksts_done(adapter) >> default: >> break; >> } >> - >> - /* Notify possible listners of interface change. */ >> - >> - rt_ifmsg(ifp); >> } >> >> static void >> > > -- > Bjoern A. Zeeb Welcome a new stage of life. > _______________________________________________ > svn-src-head@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >