From owner-cvs-src@FreeBSD.ORG Thu Sep 18 10:04:39 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6E24516A4B3 for ; Thu, 18 Sep 2003 10:04:39 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 6089B43FBF for ; Thu, 18 Sep 2003 10:04:36 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 15028 invoked by uid 1000); 18 Sep 2003 17:04:36 -0000 Date: Thu, 18 Sep 2003 10:04:36 -0700 (PDT) From: Nate Lawson To: John Baldwin In-Reply-To: <20030918170037.A8FF116A591@hub.freebsd.org> Message-ID: <20030918100414.I15008@root.org> References: <20030918170037.A8FF116A591@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include pci_cfgreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2003 17:04:39 -0000 On Thu, 18 Sep 2003, John Baldwin wrote: > Modified files: > sys/i386/include pci_cfgreg.h > Log: > Fix a busted constant related to PCI configuration acess method #1. The > reserved bits in the port that must be zero are 24:30, not 20:30. Bits > 16:23 are used to set the bus number. This meant that when we tested for > config mechanism #1, if the previous PCI configuration transaction sent > used a bus number greater than 15, one of the bits in 20:23 would be > non-zero and we would fail to use config mechanism #1 and thus fail to see > that PCI existed on the machine at all. > > Obtained from: Shanley's PCI System Architecture book > Tested by: des > Proxied through: njl > > Revision Changes Path > 1.10 +1 -1 src/sys/i386/include/pci_cfgreg.h Excellent! -Nate