Date: Sun, 31 Jul 2011 14:59:39 -0400 From: Attilio Rao <attilio@freebsd.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r224551 - head/sys/powerpc/booke Message-ID: <CAJ-FndCE5Esbwkdv%2BbqmxxBQc4Fusx68m9_30u4CckduyZTHdg@mail.gmail.com> In-Reply-To: <6C5FFE5F-7BF6-4347-8442-8DE0F4E13D2E@xcllnt.net> References: <201107311826.p6VIQlFa058340@svn.freebsd.org> <CAJ-FndBveJvrs4GpR6taRsfgDadVPMqHzFTVc%2B3MLbYwhmAAYQ@mail.gmail.com> <6C5FFE5F-7BF6-4347-8442-8DE0F4E13D2E@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
2011/7/31 Marcel Moolenaar <marcel@xcllnt.net>: > > On Jul 31, 2011, at 11:27 AM, Attilio Rao wrote: > >> I actually submitted a better fix which does use .int. >> I wasn't sure BETA1 was out, so I'm going to send a formal request now. > > Maybe we should just let it be. I don't see anything > superior with using .int that .long didn't already > fix. If anything, we could end up breaking stuff and > then having to fix it again. > > Any reason to go back in and change it again that I > can't see? Besides extending the fix to arm and mips, size_t is typedefed as int and not as long, thus I think it is more correct semantically. Pratically speaking, for booke, it doesn't change anything though. As you have the blanket on powerpc I'll do what you prefer for it, the patch is here: http://www.freebsd.org/~attilio/sintrcnt-fixup32.diff Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-FndCE5Esbwkdv%2BbqmxxBQc4Fusx68m9_30u4CckduyZTHdg>