Date: Mon, 10 Oct 2005 14:24:39 GMT From: Jean-Marc Zucconi <jmz@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/doom Makefile ports/games/doom/files patch-ag patch-sndserv__soundsrv.c patch-sndserv__wadread.c Message-ID: <200510101424.j9AEOdFW086853@freefall.freebsd.org> In-Reply-To: <20051010125906.GA3640@FreeBSD.org> References: <200510101133.j9ABXWg4000289@repoman.freebsd.org> <20051010125906.GA3640@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>>> Alexey Dokuchaev writes: > On Mon, Oct 10, 2005 at 11:33:31AM +0000, Jean-Marc Zucconi wrote: >> jmz 2005-10-10 11:33:30 UTC >> >> FreeBSD ports repository >> >> Modified files: >> games/doom Makefile >> games/doom/files patch-ag >> Added files: >> games/doom/files patch-sndserv__soundsrv.c >> patch-sndserv__wadread.c >> Log: > ... >> Replace post-patch with real patch files. > I've always been under impression that we try to avoid creating trivial > patches when desired functionality can be implemented using some > inplace-editing tools. Could you elaborate on what you've done here? I don't know if there is a rule. As the changes are on two files only I decided to not alter the submitted patch and to commit it as is. In either case this will not cause maintenance problems because the port probably will never be upgraded. Jean-Marc -- Jean-Marc Zucconi -- PGP Key: finger jmz@FreeBSD.org [KeyID: 400B38E9]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510101424.j9AEOdFW086853>