Date: Thu, 18 Jun 2020 17:04:21 +0000 From: "Tobias Kortkamp" <tobik@FreeBSD.org> To: "Mark Linimon" <linimon@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r539431 - head/lang/smlnj Message-ID: <ee9dd19a-5c85-46ea-82f5-9bc85f8cafb1@www.fastmail.com> In-Reply-To: <202006171702.05HH2ZVH019476@repo.freebsd.org> References: <202006171702.05HH2ZVH019476@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 17, 2020, at 17:02, Mark Linimon wrote: > Author: linimon > Date: Wed Jun 17 17:02:35 2020 > New Revision: 539431 > URL: https://svnweb.freebsd.org/changeset/ports/539431 > > Log: > Fix INDEX build on !x86 architectures. > > Approved by: portmgr (tier-2 blanket) > > Modified: > head/lang/smlnj/Makefile > > Modified: head/lang/smlnj/Makefile > ============================================================================== > --- head/lang/smlnj/Makefile Wed Jun 17 16:41:24 2020 (r539430) > +++ head/lang/smlnj/Makefile Wed Jun 17 17:02:35 2020 (r539431) > @@ -79,7 +79,7 @@ MLSRCS+= ${MLROOT}/${srcdir} > MLTARGETS= heap2asm > MLEXE= asdlgen heap2exec ml-antlr ml-build ml-burg ml-lex \ > ml-makedepend ml-ulex ml-yacc sml > -.if ${MLSIZE} == 32 > +.if defined(${MLSIZE}) && ${MLSIZE} == 32 > MLEXE+= ml-nlffigen > .endif Now the condition looks broken to me. defined(${MLSIZE}) is only true if MLSIZE's value happens to be a defined variable name. Instead this should be .if defined(MLSIZE) && ${MLSIZE} == 32
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ee9dd19a-5c85-46ea-82f5-9bc85f8cafb1>