From owner-svn-src-head@freebsd.org Tue Mar 31 01:59:18 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4EA062711BA; Tue, 31 Mar 2020 01:59:18 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48rsvS4gMsz3J9f; Tue, 31 Mar 2020 01:59:16 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x841.google.com with SMTP id f20so17079729qtq.6; Mon, 30 Mar 2020 18:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eLfmAWn2RrR1dw4ptDdqATaLwrpZKzx+N6UXgCk++Fw=; b=OgH3DElSyubHs8e5Lzy1+rig/h7xzmG9ITd1F4pR1CO0lV5+tGP0ONl/HoRAiynGRd O2dJ+QvQwkzwkFJPodTRsDf6KXYMQv4CqEhd7OtETdUXF88JpGtoII6z09c1id0BZUZj 8HXrVcHg8AhXrndA3cetboP3vBjCjuCWBxeVULIbgszxShkYbiJTQM4vOJsQTnFwW+fD 72iA87LkFtyQaJ0VZU3Y+QDHm8vNjxADXPRM+fI1qAwnP0z/YXOYbNBFaYsddaS7Kbvv B6AcGvHoImxKkEnPzQAV3h6nm9AquEjot5mPeZNhm4rVDWfvoMya3yEoYQqfWv527DeZ Xc5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=eLfmAWn2RrR1dw4ptDdqATaLwrpZKzx+N6UXgCk++Fw=; b=jqwIB5UIDQf2fjlXZlZq69m4WwIM8tLDHolCQmAv/Zo6uXjvUpcMc4ZciUxTDoIRfV /ArlnWvbY30oBrmU0cfEAtM5KBOYjsGLQtaUCSBADh8MsfKxcTjJZ4S5QacSZDI3Rmhe uHz0ROTqt9mWpfZC+AS0Ur6BCNQZzy2y5UyDAYvnasH7FmuM5/8Elxz9qm3T0/UU+qdt 4NpVQMlBB3NViMYbbczc1sfJBpPCqx0KPcDhOuujgWSXgjggAVD/2ELkXN6yr9guHYp/ ehHxramG7zNeCgC8LNxEAd7STQ3lphhGr2J2xeEoALXE1rAb8eZwBB4r5vWt5s8+9DGI ai3A== X-Gm-Message-State: ANhLgQ1DhA+J8c+C8VUyQRIy5EPKRlWHWcqZMWm5gQc2b1H2YSl6Z0QO zHUlANUYGIMy3zDW4qTzLnaJjCyt X-Google-Smtp-Source: ADFU+vuYVgNq8ZAVzHwJ8I7xaHqxzt11Y4V2T5Kz7vyfOZuSh4baRkk/Uv9uJNsZbLAeQTDVjri5AQ== X-Received: by 2002:aed:3244:: with SMTP id y62mr3005654qtd.242.1585619948266; Mon, 30 Mar 2020 18:59:08 -0700 (PDT) Received: from raichu (toroon0560w-lp130-10-174-94-17-182.dsl.bell.ca. [174.94.17.182]) by smtp.gmail.com with ESMTPSA id u25sm11558260qkj.71.2020.03.30.18.59.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2020 18:59:07 -0700 (PDT) Sender: Mark Johnston Date: Mon, 30 Mar 2020 21:59:05 -0400 From: Mark Johnston To: Li-Wen Hsu Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r359436 - in head/sys: kern net sys Message-ID: <20200331015905.GC65028@raichu> References: <202003301422.02UEMrxL059978@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 48rsvS4gMsz3J9f X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2020 01:59:19 -0000 On Tue, Mar 31, 2020 at 09:40:51AM +0800, Li-Wen Hsu wrote: > On Mon, Mar 30, 2020 at 10:32 PM Mark Johnston wrote: > > > > Author: markj > > Date: Mon Mar 30 14:22:52 2020 > > New Revision: 359436 > > URL: https://svnweb.freebsd.org/changeset/base/359436 > > > > Log: > > Simplify taskqgroup inititialization. > > > > taskqgroup initialization was broken into two steps: > > > > 1. allocate the taskqgroup structure, at SI_SUB_TASKQ; > > 2. initialize taskqueues, start taskqueue threads, enqueue "binder" > > tasks to bind threads to specific CPUs, at SI_SUB_SMP. > > > > Step 2 tries to handle the case where tasks have already been attached > > to a queue, by migrating them to their intended queue. In particular, > > tasks can't be enqueued before step 2 has completed. This breaks NFS > > mountroot on systems using an iflib-based driver when EARLY_AP_STARTUP > > is not defined, since mountroot happens before SI_SUB_SMP in this case. > > > > Simplify initialization: do all initialization except for CPU binding at > > SI_SUB_TASKQ. This means that until CPU binding is completed, group > > tasks may be executed on a CPU other than that to which they were bound, > > but this should not be a problem for existing users of the taskqgroup > > KPIs. > > > > Reported by: sbruno > > Tested by: bdragon, sbruno > > MFC after: 1 month > > Sponsored by: The FreeBSD Foundation > > Differential Revision: https://reviews.freebsd.org/D24188 > > > > Modified: > > head/sys/kern/subr_gtaskqueue.c > > head/sys/net/iflib.c > > head/sys/sys/gtaskqueue.h > > Hi Mark, > > I see many "panic: deadlres_td_sleep_q: possible deadlock detected" in > the CI after this commit: > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14738/consoleFull > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14739/consoleFull > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14741/consoleFull > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14742/consoleFull > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14743/console > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14744/consoleFull > > It seems could be triggered by sys.netinet6.frag6.* > sys.netpfil.common.* sbin.pfctl.pfctl_test.* tests, and there are lots > of test cases timed out. > > Can you help check these? I see, it is actually caused by r359438. I'm looking at it now.