From owner-freebsd-bugs  Thu Jul 27 11:30: 8 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2203C37C149
	for <freebsd-bugs@FreeBSD.org>; Thu, 27 Jul 2000 11:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id LAA99001;
	Thu, 27 Jul 2000 11:30:00 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from mail2.netcologne.de (mail2.netcologne.de [194.8.194.103])
	by hub.freebsd.org (Postfix) with ESMTP id 68E5537BA46
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Jul 2000 11:27:28 -0700 (PDT)
	(envelope-from pherman@frenchfries.net)
Received: from bagabeedaboo.security.at12.de (dial-195-14-235-168.netcologne.de [195.14.235.168])
	by mail2.netcologne.de (8.9.3/8.9.3) with ESMTP id UAA06053
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 27 Jul 2000 20:27:26 +0200 (MET DST)
Received: (from pherman@localhost)
	by bagabeedaboo.security.at12.de (8.10.2/8.10.2) id e6RIQI905536;
	Thu, 27 Jul 2000 20:26:18 +0200 (CEST)
Message-Id: <200007271826.e6RIQI905536@bagabeedaboo.security.at12.de>
Date: Thu, 27 Jul 2000 20:23:22 +0200 (CEST)
From: Paul Herman <pherman@frenchfries.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: bin/20225: rlogind doesn't compile without -DINET6 (w/patch!)
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         20225
>Category:       bin
>Synopsis:       rlogind doesn't compile without -DINET6
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jul 27 11:30:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Paul Herman
>Release:        FreeBSD 4.1-STABLE i386
>Organization:
>Environment:

	4.1-STABLE cvsup'ed yesterday.

>Description:

	rlogind doesn't compile without -DINET6.  I found this by
	accident as I was perusing the code.

	This is no big deal, as -DINET6 is always (?) defined, but
	then again, what's the point of having #ifdefs anyway?  :)

>How-To-Repeat:

	cd /usr/src/libexec/rlogind
	[remove -DINET6 from CFLAGS in Makefile]
	make
	[error]

>Fix:

	Like I said, it's no big deal, but neither is the patch:

------------------------------------------------------------------
--- libexec/rlogind/rlogind.c.orig	Thu Jul 27 20:07:37 2000
+++ libexec/rlogind/rlogind.c	Thu Jul 27 20:07:57 2000
@@ -231,9 +231,9 @@
 	hostname[sizeof(hostname) - 1] = '\0';
 
 	{
-		if ((fromp->su_family != AF_INET &&
+		if ((fromp->su_family != AF_INET
 #ifdef INET6
-		     fromp->su_family != AF_INET6
+		     && fromp->su_family != AF_INET6
 #endif
 		     ) ||
 		    fromp->su_port >= IPPORT_RESERVED ||

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message