Date: Thu, 28 Oct 2021 15:16:49 +0200 From: Stefan Esser <se@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 00e15405660f - main - textproc/html2text: Update CONFLICTS Message-ID: <7470b08a-2190-8a98-8e24-a3f9b0f3c183@freebsd.org> In-Reply-To: <YXoMD4Gk5Ceb757C@FreeBSD.org> References: <202110270841.19R8fLH2046856@gitrepo.freebsd.org> <YXkVJfKXVfb%2BzYR9@FreeBSD.org> <7e5125f5-2e8d-5be7-3b0c-bb4401a3c58d@freebsd.org> <YXoMD4Gk5Ceb757C@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------N6xFJNh2pLxj5yi754KutzKo Content-Type: multipart/mixed; boundary="------------c7z3oor07Vl0FVjPWE4AVsCw"; protected-headers="v1" From: Stefan Esser <se@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Message-ID: <7470b08a-2190-8a98-8e24-a3f9b0f3c183@freebsd.org> Subject: Re: git: 00e15405660f - main - textproc/html2text: Update CONFLICTS References: <202110270841.19R8fLH2046856@gitrepo.freebsd.org> <YXkVJfKXVfb+zYR9@FreeBSD.org> <7e5125f5-2e8d-5be7-3b0c-bb4401a3c58d@freebsd.org> <YXoMD4Gk5Ceb757C@FreeBSD.org> In-Reply-To: <YXoMD4Gk5Ceb757C@FreeBSD.org> --------------c7z3oor07Vl0FVjPWE4AVsCw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 28.10.21 um 04:33 schrieb Alexey Dokuchaev: > On Wed, Oct 27, 2021 at 08:25:13PM +0200, Stefan Esser wrote: >> Am 27.10.21 um 11:00 schrieb Alexey Dokuchaev: >>>> ... >>>> -CONFLICTS=3D py27-html2text-[0-9]* >>>> +CONFLICTS=3D py*-html2text-[0-9]* >>> >>> I recal, last time I've tried to specify a conflict without the -[0-9= ]* >>> suffix and it worked as expected. Are those really necessary in defa= ult >>> "all versions" case? >> >> And quite a few CONFLICTS specifications should actually be >> CONFLICTS_INSTALL. But it takes a lot of work to check whether there >> really is a build conflict for each of the combinations... >=20 > I'm not sure if CONFLICTS alone is justified, and why can't we always > use correct CONFLICTS_$TYPE. Checking if CONFLICTS should really be > CONFLICTS_INSTALL could be automated, or so it seems at least for cases= > when prerequisite are met, by comparing pkg-plists of ports in question= =2E >=20 > CONFLICTS_BUILD are tougher; whenever I added one, it was as a result > of stumbling across local build problem and wondering why it does not > happen on the cluster, i.e. in pristine environment. >=20 > Overall, many good points Stefan, nice write up. So that even if you > won't pick up on this task, someone might now that you've made it less > of an uncharted territory. Well, I went ahead and have generated a list of ports that have the redundant "-[0-9]*" version suffix in CONFLICTS patterns. As of today, these are 388 ports in total. It was easy to write a script that removes those suffices and I have generated a review: https://reviews.freebsd.org/D32703 If that review was accepted by portmgr@, it would clean up the ports tree with regards to this issue. Else I can send patches to individual port maintainers and ask them for approval or let them apply the patches to their ports. This does not address CONFLICTS vs. CONFLICTS_INSTALL or other aspects, obviously. But I think it is still a reasonable simplification and does prevent permeation of -[0-9]* suffices when a new port is created based on an existing one with this version wildcard present ... Regards, STefan --------------c7z3oor07Vl0FVjPWE4AVsCw-- --------------N6xFJNh2pLxj5yi754KutzKo Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmF6osEFAwAAAAAACgkQR+u171r99USF dAf9EPT3+rogmg6DS3tPUX+SrG1MciTztm5Cdvad2osh7HKWx88pENyTIkmZbq89u1RV+nvhRTUD hpmliTKc/LEwqU6L5nUXF+chrTO56l+laZHBbGCx2TnN8QCm/vypwGTCW8eEUIsLVoGVDLx6R/+1 1FFSaAK8XesRyklPzecCFDchsXZ3Gt8XRwVw10MJ3fLP6RRAWJYDpMetEY2vT7fkyP8aFbXKoVGI 6ty5tf0aXOmzVTvAcqx0P11k460bgyVAAjx0mGX2td7QI7uF38vpECnwGcpv+tdOq8fcxKt5afiO 4wgeOp82bD4W1ZSPlFSJjbiD0mD9CU9Lf3SYhkKBMQ== =y6Xx -----END PGP SIGNATURE----- --------------N6xFJNh2pLxj5yi754KutzKo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7470b08a-2190-8a98-8e24-a3f9b0f3c183>