Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 Jun 2007 12:44:19 GMT
From:      Rui Paulo <rpaulo@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 122395 for review
Message-ID:  <200706271244.l5RCiJuJ027864@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=122395

Change 122395 by rpaulo@rpaulo_epsilon on 2007/06/27 12:44:09

	Remove the UQ_MS_IGNORE quirk. The atp driver only needs to return
	a proper value in the attach routine to win the device against
	ums(4).

Affected files ...

.. //depot/projects/soc2007/rpaulo-macbook/dev/usb/ums.c#11 edit
.. //depot/projects/soc2007/rpaulo-macbook/dev/usb/usb_quirks.c#5 edit
.. //depot/projects/soc2007/rpaulo-macbook/dev/usb/usb_quirks.h#5 edit

Differences ...

==== //depot/projects/soc2007/rpaulo-macbook/dev/usb/ums.c#11 (text+ko) ====

@@ -188,9 +188,6 @@
 	void *desc;
 	usbd_status err;
 
-	if (usbd_get_quirks(uaa->device)->uq_flags & UQ_MS_IGNORE)
-		return (UMATCH_NONE);
-
 	if (!uaa->iface)
 		return (UMATCH_NONE);
 	id = usbd_get_interface_descriptor(uaa->iface);

==== //depot/projects/soc2007/rpaulo-macbook/dev/usb/usb_quirks.c#5 (text+ko) ====

@@ -102,7 +102,7 @@
 	ANY, { UQ_KBD_IGNORE }},
  /* Devices that need special handling of the Fn key */
  { USB_VENDOR_APPLE, USB_PRODUCT_APPLE_INTKBTP,
-	ANY, { UQ_KBD_FNKEY | UQ_MS_IGNORE } },
+	ANY, { UQ_KBD_FNKEY } },
  { 0, 0, 0, { 0 } }
 };
 

==== //depot/projects/soc2007/rpaulo-macbook/dev/usb/usb_quirks.h#5 (text+ko) ====

@@ -56,7 +56,6 @@
 #define UQ_HID_IGNORE	0x8000	/* device should be ignored by hid class */
 #define UQ_KBD_IGNORE  0x18000	/* device should be ignored by both kbd and hid class */
 #define UQ_KBD_FNKEY	0x40000	/* device needs special handling for the Fn key */
-#define UQ_MS_IGNORE	0x20000 /* device should be ignored by ums */
 };
 
 extern const struct usbd_quirks usbd_no_quirk;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200706271244.l5RCiJuJ027864>