From owner-cvs-all@FreeBSD.ORG Wed Sep 17 07:05:17 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D722E16A4B3; Wed, 17 Sep 2003 07:05:17 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 689EC43FE0; Wed, 17 Sep 2003 07:05:17 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h8HE5HXJ078633; Wed, 17 Sep 2003 07:05:17 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h8HE5G5h078628; Wed, 17 Sep 2003 07:05:16 -0700 (PDT) (envelope-from bde) Message-Id: <200309171405.h8HE5G5h078628@repoman.freebsd.org> From: Bruce Evans Date: Wed, 17 Sep 2003 07:05:16 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/sio sio.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2003 14:05:18 -0000 bde 2003/09/17 07:05:16 PDT FreeBSD src repository Modified files: sys/dev/sio sio.c Log: Cleaned up initialization of hardware flow control for 16650As. Use defined values instead of hard-coded values. Don't repeat the register access part of the code 4 times times or triple-space statements. This fixes half of the style bugs in rev.1.172. Hardware flow control of 16650As is still officially unsupported. I was mistaken about it being broken. It is broken in 16650s but is fixed in 16650As except for the maximum trigger level (which is no longer used). Testing of the 16650's broken hardware flow control watermarks by programming them on 16950s showed that their effects are not too bad if the fifo size and trigger level are reasonably large (16 is much better than 8). Revision Changes Path 1.406 +11 -25 src/sys/dev/sio/sio.c