Date: Mon, 15 Aug 2016 09:16:00 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Bruce Evans <bde@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r304153 - head/sys/dev/syscons Message-ID: <20160815131600.GA86798@mutt-hardenedbsd> In-Reply-To: <201608151256.u7FCujHw048832@repo.freebsd.org> References: <201608151256.u7FCujHw048832@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 15, 2016 at 12:56:45PM +0000, Bruce Evans wrote: > Author: bde > Date: Mon Aug 15 12:56:45 2016 > New Revision: 304153 > URL: https://svnweb.freebsd.org/changeset/base/304153 >=20 > Log: > Quick fix for locking fixes in r172250. The lock added there was per- > virtual-device, but needs to be per-physical-device so that it protects > shared data. Usually, scp->sc->write_in_progress got corrupted first > and further corruption was limited when this variable was left at nonze= ro > with no write in progress. > =20 > Attempt to fix missing lock destruction in r162285. Put it with the > lock destruction for r172250 after moving the latter. Both might be > unreachable. > =20 > To demonstrate the bug, find a buggy syscall or sysctl that calls > printf(9) and run this often. Run hd /dev/zero >/dev/ttyvN for any > N !=3D 0. The console spam goes to ttyv0 and the non-console spam goes > to ttyvN, so the lock provided no protection (but it helped for > N =3D=3D 0). >=20 Hey Bruce, Should this be MFC'd after some point? Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXscCMAAoJEGqEZY9SRW7uxugP/iMpq3pF0akMPnu0Jf/WyuHw CGNCn2bCde1OP0PHUG0u+zkD5ri0N5r2wPanQtbKpw4fS+5SZB0iSnus21BhzUb0 vGkUrfe8TRv0IWwDW5JRa6dFqs5mW7WA+4YpVxH8huarJ00GGyKVpFuSUEPmURHR kCXswD8bx9J4b16myW/wpBv5nvRwtJ5bGoRszDnG/Stk3DMnSRlTYiHr6Wfgi7dz jbHrH4OzdOz9WXzN+JsQ3SOnyX1ruCVzsidLflzdB8O4PXtdB5khewQnSTUiltY4 P5nPpx6drQKCaZeCI+ZnIzc4VScxRaP67YOIgES4EZAtQ310+HoWqWkhIUDcdC6D qDnG71nHiuhhzEyJBKVY2FO+9pLr6e1q0ecDrouv9D2J6O3s2fh8Tmnds+ONRMe/ pNZr5r2QukATM+0NSZSQtF9yVpO+dcFda9neDI6wIWj3Dfx2Tyh3K5LNiioUC3hJ MvYmpYwcwi3dj1GPJXVlDxEusk0n+4w3uOMwXihfwSlK23soVourL1SyvlaEazUd +knWqHKaWQxaytBr/f9KPXEuJ9GsSLu/jv4NdbekocrDFNv1Zv7YyAEkRBj2RsQD 9EzCmbBbqiUNha8Bv9GKPBxOLVTEywwU57my4nznqqpUTT2NtqUDAKATOchvM0zM RHdM/geV/5MhW7IkizzJ =s/uo -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160815131600.GA86798>