Date: Mon, 2 Mar 2015 08:34:42 +0100 From: Antoine Brodin <antoine@FreeBSD.org> To: John Marino <marino@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r380211 - head/security/libgpg-error Message-ID: <CAALwa8nRzuy8VfGwxKdO42tSdR-1ixiak1yKWzmn8rW-NrHpUg@mail.gmail.com> In-Reply-To: <54F37212.3010800@marino.st> References: <201503011652.t21GqiLh056130@svn.freebsd.org> <CAALwa8mhQ7bX5TeaUa7Wrw7fy5TV0ZxZqOS_Zjs3tAC-MUf5LQ@mail.gmail.com> <54F3458E.8090401@marino.st> <CAALwa8nnv3a7GpOqbe%2BBatjmeW-_mba2iaSok3iOWrP_EMZOnw@mail.gmail.com> <54F34DC3.8020902@marino.st> <CAALwa8n6hR8aYw7Z=b-JGUyG3u4_HLvNgJDZT%2BXgqkCnjoHZnA@mail.gmail.com> <54F35AAD.5010200@marino.st> <CAALwa8mk8-eGWmg6QYcFqkt%2BSR687YZqq0tTcegf%2BEwJbX8kxg@mail.gmail.com> <54F3678C.90706@marino.st> <CAALwa8m=%2B6ADnKtUaNFxY10jFjJsD%2BzZOARRn8RTxoMOd1S1JA@mail.gmail.com> <54F37212.3010800@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 1, 2015 at 9:09 PM, John Marino <freebsd.contact@marino.st> wrote: > On 3/1/2015 21:05, Antoine Brodin wrote: >> On Sun, Mar 1, 2015 at 8:25 PM, John Marino <freebsd.contact@marino.st> wrote: >>> On 3/1/2015 19:46, Antoine Brodin wrote: >>>> Can you try using cpp5 -P instead of cpp5? >>>> See http://www.gnu.org/software/gcc/gcc-5/porting_to.html >>>> >>> >>> It works. If I just add "CPP= cpp -P" to the stock port makefile, then >>> it builds fine. I check "cpp -P" on FreeBSD 10, it seems clang cpp just >>> ignores the -P even though it's not a listed option. >>> >>> I guess if we want to use this, the fix would be something like >>> "CPP+= -P" >>> >>> Would all the FreeBSD releases accept "CPP+= -P" ? >> >> I tested the src/Makefile.in part of >> https://build.opensuse.org/source/openSUSE:Factory/libgpg-error/libgpg-error-1.18-gcc5.patch >> on FreeBSD 8.4 / 9.3 / 10.1 / head / head with clang 3.6 and it >> worked. > > Nice to know. What is the rationale for patching the makefiles if > defining CPP in the environment has the same result? > > Just curious because it seems that "CPP+= -P" saves three patches and > I'd think that would be desired. A patch can be submitted upstream (it's not fixed in libgpg-error git and no one opened a bug about it yet) Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8nRzuy8VfGwxKdO42tSdR-1ixiak1yKWzmn8rW-NrHpUg>