From owner-svn-src-all@FreeBSD.ORG Tue Dec 13 15:36:09 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 37D84106564A; Tue, 13 Dec 2011 15:36:09 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id A20768FC0C; Tue, 13 Dec 2011 15:36:08 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 5C2BEAE6; Tue, 13 Dec 2011 16:36:07 +0100 (CET) Date: Tue, 13 Dec 2011 16:35:06 +0100 From: Pawel Jakub Dawidek To: Eitan Adler Message-ID: <20111213153506.GC1659@garage.freebsd.pl> References: <201112131400.pBDE0S6M053401@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mvpLiMfbWzRoNl4x" Content-Disposition: inline In-Reply-To: <201112131400.pBDE0S6M053401@svn.freebsd.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228470 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2011 15:36:09 -0000 --mvpLiMfbWzRoNl4x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2011 at 02:00:28PM +0000, Eitan Adler wrote: > Author: eadler (ports committer) > Date: Tue Dec 13 14:00:27 2011 > New Revision: 228470 > URL: http://svn.freebsd.org/changeset/base/228470 >=20 > Log: > - Add a sysctl to allow non-root users the ability to set idle > priorities. [...] I'd suggest using consistent style with those two: [...] > + unprivileged_idprio =3D=3D 0)) { [...] > + !unprivileged_idprio)) { [...] Because it should be either 0 or 1, the latter is better. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --mvpLiMfbWzRoNl4x Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk7ncKoACgkQForvXbEpPzTNYgCgl4/ZJrmmjPmntJy4+hf5v7Oz /B0An2U19PGf6a33HWq2j30qc+9XNUWF =ymwP -----END PGP SIGNATURE----- --mvpLiMfbWzRoNl4x--