Date: Mon, 20 Sep 2004 13:43:53 -0400 From: John Baldwin <jhb@FreeBSD.org> To: David Schultz <das@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_proc.c kern_switch.c src/sys/sys sched.h src/sys/vm vm_glue.c Message-ID: <200409201343.53529.jhb@FreeBSD.org> In-Reply-To: <200409191834.i8JIYHXU089517@repoman.freebsd.org> References: <200409191834.i8JIYHXU089517@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday 19 September 2004 02:34 pm, David Schultz wrote: > das 2004-09-19 18:34:17 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_proc.c kern_switch.c > sys/sys sched.h > sys/vm vm_glue.c > Log: > The zone from which proc structures are allocated is marked > UMA_ZONE_NOFREE to guarantee type stability, so proc_fini() should > never be called. Move an assertion from proc_fini() to proc_dtor() > and garbage-collect the rest of the unreachable code. I have retained > vm_proc_dispose(), since I consider its disuse a bug. Arguably the UMA_ZONE_NOFREE bit is the bug. Do we know what code assumes type stability of proc structures? -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200409201343.53529.jhb>