From owner-freebsd-current@FreeBSD.ORG  Wed Apr  2 20:06:26 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B4BA91065671;
	Wed,  2 Apr 2008 20:06:26 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 9E6988FC27;
	Wed,  2 Apr 2008 20:06:26 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 0E9081A4D7E;
	Wed,  2 Apr 2008 13:06:26 -0700 (PDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Wed, 2 Apr 2008 16:04:47 -0400
User-Agent: KMail/1.9.7
References: <20080303200946.GA79061@freebsd.org>
	<20080304111542.GA57756@deviant.kiev.zoral.com.ua>
	<20080330214947.GA16374@freebsd.org>
In-Reply-To: <20080330214947.GA16374@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <200804021604.48208.jhb@freebsd.org>
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Kostik Belousov <kostikbel@gmail.com>, Roman Divacky <rdivacky@freebsd.org>
Subject: Re: shared lock instead of exclusive in set_rootvnode
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Apr 2008 20:06:26 -0000

On Sunday 30 March 2008 05:49:47 pm Roman Divacky wrote:
> On Tue, Mar 04, 2008 at 01:15:42PM +0200, Kostik Belousov wrote:
> > On Mon, Mar 03, 2008 at 09:09:46PM +0100, Roman Divacky wrote:
> > > hi
> > >
> > > in set_rootvnode() there is
> > >
> > > p->p_fd->fd_cdir = rootvnode;
> > > p->p_fd->fd_rdir = rootvnode;
> > >
> > > protected just by FILEDESC_SLOCK(), I dont think this is correct
> > > although it might be benign as this is used only during boot.
> > >
> > > still, if it's not correct it should be fixed
> > >
> > > comments?
> >
> > Seems right. Did you boot with patched kernel ?
>
> I've been running with this patch for a month... is it time to commit
> this?

Go for it.

-- 
John Baldwin