Date: Mon, 4 Jun 2018 08:18:34 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Matt Macy <mmacy@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334609 - head/usr.sbin/pmc Message-ID: <201806041518.w54FIYRZ096337@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201806040630.w546UaRJ005645@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > Author: mmacy > Date: Mon Jun 4 06:30:35 2018 > New Revision: 334609 > URL: https://svnweb.freebsd.org/changeset/base/334609 > > Log: > pmc filter: avoid spurious gcc uninitialized warning Is it truely uninitialzized, or are you silencing a bogus warning, this commit and the code does not make that clear, and that should be made clear. Thanks, Rod > > Modified: > head/usr.sbin/pmc/cmd_pmc_filter.c > > Modified: head/usr.sbin/pmc/cmd_pmc_filter.c > ============================================================================== > --- head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 05:55:40 2018 (r334608) > +++ head/usr.sbin/pmc/cmd_pmc_filter.c Mon Jun 4 06:30:35 2018 (r334609) > @@ -145,7 +145,7 @@ pmc_filter_handler(uint32_t *lwplist, int lwpcount, ui > if ((ps = pmclog_open(infd)) == NULL) > errx(EX_OSERR, "ERROR: Cannot allocate pmclog parse state: %s\n", strerror(errno)); > > - pmccount = 0; > + eventcount = pmccount = 0; > while (pmclog_read(ps, &ev) == 0) { > if (ev.pl_type == PMCLOG_TYPE_INITIALIZE) > memcpy(cpuid, ev.pl_u.pl_i.pl_cpuid, PMC_CPUID_LEN); > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201806041518.w54FIYRZ096337>