Date: 26 Jul 1999 11:05:59 +0200 From: Dag-Erling Smorgrav <des@flood.ping.uio.no> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: Dag-Erling Smorgrav <des@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/inetd Makefile Message-ID: <xzp3dybbx1k.fsf@flood.ping.uio.no> In-Reply-To: "Brian F. Feldman"'s message of "Mon, 26 Jul 1999 04:57:27 -0400 (EDT)" References: <Pine.BSF.4.10.9907260448450.17218-100000@janus.syracuse.net>
next in thread | previous in thread | raw e-mail | index | archive | help
"Brian F. Feldman" <green@FreeBSD.org> writes: > Here's one way to start cleaning it up: remove OLD_SETPROCTITLE cruft. patches? > Problem: is this line right? > syslog(LOG_ERR, "pipe: %%m"); probably not, there should be only one %. > Another: (type *)0 should be NULL. Lots of those. patches? > SWAP should die. typeof() is not portable. SWAP could take a type specifier as a third argument (I'd place it first, actually). > turnon() is lame, and should be shot. patches? > Lots more bogus casts. For instance: > sep = (struct servtab *)malloc(sizeof (*sep)); patches? DES -- Dag-Erling Smorgrav - des@flood.ping.uio.no To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xzp3dybbx1k.fsf>