Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 09 Oct 2001 10:29:06 -0700 (PDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Brian Somers <brian@freebsd-services.com>
Cc:        cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject:   Re: cvs commit: src/sys/i386/isa pcaudio.c
Message-ID:  <XFMail.011009102906.jhb@FreeBSD.org>
In-Reply-To: <200110090934.f999Yo489935@hak.lan.Awfulhak.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 09-Oct-01 Brian Somers wrote:
>> jhb         2001/10/08 16:35:40 PDT
>> 
>>   Modified files:
>>     sys/i386/isa         pcaudio.c 
>>   Log:
>>   Don't attempt to initialize the pcaudio device on open.  The attach
>>   routine
>>   already does the initialization (though it didn't set pca_initialized, so
>>   we always initialized twice) and since attach calls make_dev(), there's no
>>   way that pcaopen() can be called before pcaattach().
>>   
>>   Revision  Changes    Path
>>   1.63      +1 -7      src/sys/i386/isa/pcaudio.c
> 
> Surely pcaopen() can be called before pcaattach() on a non-devfs 
> system (or does something else head the call off with an ENXIO) ?

Wouldn't newbus do the pcaattach() before pcaopen() could possibly ever be
called?  Also, how else besides make_dev() does a device associate it's cdevsw
with a major number?

-- 

John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011009102906.jhb>