Date: Sat, 08 May 1999 11:23:35 -0700 From: Mike Smith <mike@smith.net.au> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: current@freebsd.org Subject: Re: m_get(M_WAIT, ...) _can_ return NULL ? Message-ID: <199905081823.LAA01001@dingo.cdrom.com> In-Reply-To: Your message of "Sat, 08 May 1999 15:32:33 %2B0200." <199905081332.PAA07452@labinfo.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
> Hi, > > thinking about the supposed "fragility" of FreeBSD when mbufs (or > clusters) are not properly dimensioned: i notice that > in various places of the code (and this is, i think, 4.4 heritage), > there are things like > > m = m_get(M_WAIT, ...) > m->m_len = something. > > looking at the code, it seems that m_get() _can_ return a NULL pointer > even if one specifies M_WAIT. > > Could this be a potential weakness, and in this case, how shuld we go > and fix it -- by making m_get never return if there is no memory, > or by hunting all such occurrences of the code ? I engaged in part of a sweep of this sort with Andrzej a while back, but he never committed any of the changes. I'm not quite sure why. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199905081823.LAA01001>